Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[install] pytorch-optimizer dropped RAdam #568

Merged

Conversation

ben-freist
Copy link
Contributor

In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from pytorch-optimizer, it's still used in asteroid though. So we restrict the version to be earlier than 0.2.0.

In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from
pytorch-optimizer, it's still used in aseroid though.
@mpariente
Copy link
Collaborator

That looks perfect, but the docs are failing for some reason.
@JorisCos, would you like to have a look at that?

@mpariente
Copy link
Collaborator

Reagardless, I think I'll merge because in the current state, asteroid cannot even be imported.

@mpariente mpariente merged commit d21a188 into asteroid-team:master Oct 28, 2021
@mpariente
Copy link
Collaborator

Thanks!

@ben-freist ben-freist deleted the fix-torch-optimizer-version branch October 29, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants