Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule SIM300 cause autofix error #7125

Closed
qarmin opened this issue Sep 4, 2023 · 1 comment · Fixed by #7167
Closed

Rule SIM300 cause autofix error #7125

qarmin opened this issue Sep 4, 2023 · 1 comment · Fixed by #7167
Assignees
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 4, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select SIM300 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

B<A[0][0]or B

error

/home/rafal/test/tmp_folder/663898301978.py:1:1: SIM300 Yoda conditions are discouraged, use `A[0][0]>B` instead
Found 1 error.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/663898301978.py`, the rule codes SIM300, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

python_compressed.zip

@MichaReiser MichaReiser added bug Something isn't working fuzzer Surfaced via fuzzing. labels Sep 4, 2023
@dhruvmanila
Copy link
Member

We're fixing this as A[0][0]>Bor B. It seems that the "no whitespace between A[0][0] and or keyword is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants