Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin rustpython to the same revision to fix cargo vendor #2069

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented Jan 21, 2023

I was trying to update ruff in nixpkgs and ran into this error when it was running cargo vendor

error: failed to sync

Caused by:
  found duplicate version of package `rustpython-ast v0.2.0` vendored from two sources:

        source 1: https://github.com/RustPython/RustPython.git?rev=62aa942bf506ea3d41ed0503b947b84141fdaa3c#62aa942b
        source 2: https://github.com/RustPython/RustPython.git?rev=ff90fe52eea578c8ebdd9d95e078cc041a5959fa#ff90fe52

@charliermarsh
Copy link
Member

Ah thank you, sorry, total oversight on my part. Will you be able to update it without a new PyPI release? (Assuming yes, if you're running cargo vendor.)

@figsoda
Copy link
Contributor Author

figsoda commented Jan 21, 2023

We use the github tagged version, so maybe something like a v0.0.229-vendor tag would help. I can always just wait for the next release when there are more notable changes since ruff seems to get updates pretty frequently

@charliermarsh charliermarsh merged commit b1bda0d into astral-sh:main Jan 21, 2023
@charliermarsh
Copy link
Member

Okay sounds good. Yeah, we'll probably release again tomorrow.

@figsoda figsoda deleted the pin branch January 21, 2023 19:41
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.229` ->
`^0.0.230` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/compatibility-slim/0.0.229)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/confidence-slim/0.0.229)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.230`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.230)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.229...v0.0.230)

#### What's Changed

- fix: pin rustpython to the same revision to fix cargo vendor by
[@&#8203;figsoda](https://togithub.com/figsoda) in
[astral-sh/ruff#2069
- feat: implementation for TRY004 by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2066
- ICN001 import-alias-is-not-conventional should check "from" imports by
[@&#8203;Zeddicus414](https://togithub.com/Zeddicus414) in
[astral-sh/ruff#2070
- Update link to Pylint parity tracking issue by
[@&#8203;cosmojg](https://togithub.com/cosmojg) in
[astral-sh/ruff#2074
- ICN001 check from imports that have no alias by
[@&#8203;Zeddicus414](https://togithub.com/Zeddicus414) in
[astral-sh/ruff#2072
- Index source code upfront to power (row, column) lookups by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1990
- Remove remaining `ropey` usages by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2076
- Include package path in cache key by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2077
- feat: update scripts to new rules structure by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2078
- Base `INP` check on package inference by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2079
- Improve generator precedence operations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2080
- Support decorators in source code generator by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2081
- feat: enable autofix for TRY004 by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2084
- Refactor, decouple and support "PL" by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#2051
- \[`pep8-naming`]\[`N806`] Don't mark `TypeVar` & `NewType` Assignment
as Errors by [@&#8203;saadmk11](https://togithub.com/saadmk11) in
[astral-sh/ruff#2085
- Update linters pypi links to latest version by
[@&#8203;alonme](https://togithub.com/alonme) in
[astral-sh/ruff#2062
- flake8\_to_ruff: support `isort` options by
[@&#8203;shannonrothe](https://togithub.com/shannonrothe) in
[astral-sh/ruff#2082
- Update RustPython to fix `Dict.keys` type by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#2086

#### New Contributors

- [@&#8203;figsoda](https://togithub.com/figsoda) made their first
contribution in
[astral-sh/ruff#2069
- [@&#8203;cosmojg](https://togithub.com/cosmojg) made their first
contribution in
[astral-sh/ruff#2074
- [@&#8203;alonme](https://togithub.com/alonme) made their first
contribution in
[astral-sh/ruff#2062
- [@&#8203;shannonrothe](https://togithub.com/shannonrothe) made their
first contribution in
[astral-sh/ruff#2082

**Full Changelog**:
astral-sh/ruff@v0.0.229...v0.0.230

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDguNCIsInVwZGF0ZWRJblZlciI6IjM0LjEwOC40In0=-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants