Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update scripts to new rules structure #2078

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Jan 22, 2023

  • optional prefix argument for add_plugin.py
  • rules directory instead of rules.rs
  • pathlib syntax
  • fix test case where code was added instead of name

Example:

python scripts/add_plugin.py --url https://pypi.org/project/example/1.0.0/ example --prefix EXA
python scripts/add_rule.py --name SecondRule --code EXA002 --linter example
python scripts/add_rule.py --name FirstRule --code EXA001 --linter example
python scripts/add_rule.py --name ThirdRule --code EXA003 --linter example

Note that it breaks compatibility with 'old style' plugins (generation works fine, but namespaces need to be changed):

python scripts/add_rule.py --name DoTheThing --code PLC999 --linter pylint

- optional `prefix` argument for `add_plugin.py`
- rules directory instead of `rules.rs`
- pathlib syntax
- fix test case where code was added instead of name

Example:
```
python scripts/add_plugin.py --url https://pypi.org/project/example/1.0.0/ example --prefix EXA
python scripts/add_rule.py --name SecondRule --code EXA002 --linter example
python scripts/add_rule.py --name FirstRule --code EXA001 --linter example
 python scripts/add_rule.py --name ThirdRule --code EXA003 --linter example
 ```
create at least one rule for the plugin
@sbrugman sbrugman marked this pull request as draft January 22, 2023 00:13
@sbrugman sbrugman marked this pull request as ready for review January 22, 2023 00:15
@charliermarsh charliermarsh merged commit 28f05aa into astral-sh:main Jan 22, 2023
@sbrugman sbrugman deleted the scripts-update branch January 22, 2023 00:20
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.229` ->
`^0.0.230` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/compatibility-slim/0.0.229)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.230/confidence-slim/0.0.229)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.230`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.230)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.229...v0.0.230)

#### What's Changed

- fix: pin rustpython to the same revision to fix cargo vendor by
[@&#8203;figsoda](https://togithub.com/figsoda) in
[astral-sh/ruff#2069
- feat: implementation for TRY004 by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2066
- ICN001 import-alias-is-not-conventional should check "from" imports by
[@&#8203;Zeddicus414](https://togithub.com/Zeddicus414) in
[astral-sh/ruff#2070
- Update link to Pylint parity tracking issue by
[@&#8203;cosmojg](https://togithub.com/cosmojg) in
[astral-sh/ruff#2074
- ICN001 check from imports that have no alias by
[@&#8203;Zeddicus414](https://togithub.com/Zeddicus414) in
[astral-sh/ruff#2072
- Index source code upfront to power (row, column) lookups by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1990
- Remove remaining `ropey` usages by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2076
- Include package path in cache key by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2077
- feat: update scripts to new rules structure by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2078
- Base `INP` check on package inference by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2079
- Improve generator precedence operations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2080
- Support decorators in source code generator by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2081
- feat: enable autofix for TRY004 by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2084
- Refactor, decouple and support "PL" by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#2051
- \[`pep8-naming`]\[`N806`] Don't mark `TypeVar` & `NewType` Assignment
as Errors by [@&#8203;saadmk11](https://togithub.com/saadmk11) in
[astral-sh/ruff#2085
- Update linters pypi links to latest version by
[@&#8203;alonme](https://togithub.com/alonme) in
[astral-sh/ruff#2062
- flake8\_to_ruff: support `isort` options by
[@&#8203;shannonrothe](https://togithub.com/shannonrothe) in
[astral-sh/ruff#2082
- Update RustPython to fix `Dict.keys` type by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#2086

#### New Contributors

- [@&#8203;figsoda](https://togithub.com/figsoda) made their first
contribution in
[astral-sh/ruff#2069
- [@&#8203;cosmojg](https://togithub.com/cosmojg) made their first
contribution in
[astral-sh/ruff#2074
- [@&#8203;alonme](https://togithub.com/alonme) made their first
contribution in
[astral-sh/ruff#2062
- [@&#8203;shannonrothe](https://togithub.com/shannonrothe) made their
first contribution in
[astral-sh/ruff#2082

**Full Changelog**:
astral-sh/ruff@v0.0.229...v0.0.230

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDguNCIsInVwZGF0ZWRJblZlciI6IjM0LjEwOC40In0=-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants