Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the scope of useless-expression (B018) #3455

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

charliermarsh
Copy link
Member

Closes #3453.

@charliermarsh
Copy link
Member Author

I wanna see how this affects the ecosystem CI check, this might be too broad.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2023

ℹ️ ecosystem check detected changes. (+345, -0, 0 error(s))

zulip (+2, -0)

+ zerver/apps.py:32:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ zerver/views/realm.py:185:5: B018 Found useless expression. Either assign it to a variable or remove it.

bokeh (+308, -0)

+ tests/codebase/test_code_quality.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_eslint.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_importlib_metadata.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_isort.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_js_license_set.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_json.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_license.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_client_server_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_ipython_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_pandas_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_request_host.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_selenium_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_tornado_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_typing_extensions_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_python_execution_with_OO.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_ruff.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_windows_reserved_filenames.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/embed/test_json_item.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/models/test_datarange1d.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/models/test_plot.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/models/test_sources.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/test_regressions.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_box_edit_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_box_zoom_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_custom_action.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_freehand_draw_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_pan_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_point_draw_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_poly_draw_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_poly_edit_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_range_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_reset_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_tap_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_wheel_pan_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_wheel_zoom_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_zoom_in_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_zoom_out_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_cell_editors.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_copy_paste.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_data_table.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_sortable.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_source_updates.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_autocomplete_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_button.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_checkbox_button_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_checkbox_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_color_picker.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_copy_paste.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_datepicker.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_daterange_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_dateslider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_datetime_range_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_div.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_dropdown.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_multi_choice.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_numeric_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_paragraph.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_password_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_pretext.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_radio_button_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_radio_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_range_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_select.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_spinner.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_text_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_textarea_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_toggle.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_bokehjs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_defaults.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_examples.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/_testing/util/test_env.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test___init___handlers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_code.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_code_runner.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_directory.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_document_lifecycle.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_function.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_notebook__handlers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_script.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_server_lifecycle.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_server_request_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/test___init___application.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/test_application.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test___init___client.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_connection.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_session__client.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_states.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_util__client.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_websocket.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test___init___colors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_color__colors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_groups.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_named.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_util__colors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test___init___subcommands.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_info.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_json__subcommands.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_sampledata__subcommands.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_secret.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_serve.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test___init___command.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test_bootstrap.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test_subcommand.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test_util__command.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/_util_property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test___init___property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_alias.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_aliases.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_any.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_auto.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_bases.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_color__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_container.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_dataspec.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_datetime.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptor_factory.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:110:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:111:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:112:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:113:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_either.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_enum.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_include.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_instance.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_json__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_nullable.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_numeric.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_override.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_pd.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_primitive.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_required.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_singletons.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_string_properties.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_validation__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_vectorization.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_visual.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_wrappers__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_enums.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:121:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:126:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:131:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:136:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_json_encoder.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_properties.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_properties.py:367:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_properties.py:391:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_query.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_serialization.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_templates.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_validation.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/_util_document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_callbacks__document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_events__document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_locking.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_modules.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test___init___embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_bundle.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_elements.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_notebook__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_server__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_standalone.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_util__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_wrappers__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test___init___io.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_export.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_notebook__io.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_output.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_saving.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_showing.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_state.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_util__io.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_webdriver.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test___init___model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_data_model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_docs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_util_model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/_util_models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_annotations.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_axes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_callbacks__models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_defaults.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_dom.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_filters.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_formatters.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_glyph_renderer.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_glyphs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_glyphs.py:88:1: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_graph_renderer.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_graphs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_grids.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_layouts__models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_mappers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_plots.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_plots.py:491:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_ranges.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_sources.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_tools.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_transforms.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/util/test_structure.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:139:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:141:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:47:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:49:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:59:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:61:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:93:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:95:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test___init___plotting.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__decorators.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__graph.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__legends.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__plot.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__renderer.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__stack.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__tools.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test_contour.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test_figure.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test_graph.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/messages/test_patch_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/messages/test_pull_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/messages/test_push_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/test_message.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/test_receiver.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test___init___sampledata.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_airport_routes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_airports.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_anscombe.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_antibiotics.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_autompg.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_autompg2.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_browsers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_commits.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_daylight.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_degrees.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_gapminder.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_glucose.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_haar_cascade.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_iris.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_les_mis.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_movies_data.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_mtb.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_olympics2014.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_perceptions.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_periodic_table.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_population.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sample_geojson.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sample_superstore.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sea_surface_temperature.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sprint.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_stocks.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_unemployment.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_unemployment1948.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_cities.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_counties.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_holidays.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_marriages_divorces.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_states.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_world_cities.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_auth_provider.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_callbacks__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_contexts.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_server__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_session__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_tornado__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_util.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_metadata_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_root_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_session_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_ws.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test___init__.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test___main__.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_client_server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_driving.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_events.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_ext.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_layouts.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_objects.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_palettes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_settings.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_themes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_tile_providers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_transform.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_browser.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_callback_manager.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_compiler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_dataclasses.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_dependencies.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_deprecation.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_hex.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_options.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_package.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_sampledata__util.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_strings.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_token.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_tornado__util.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_util__serialization.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_version.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_warnings.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.

airflow (+35, -0)

+ airflow/providers/cncf/kubernetes/hooks/kubernetes.py:245:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/ftp/hooks/ftp.py:274:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/github/hooks/github.py:85:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_looker.py:63:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:423:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:428:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:583:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:638:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:710:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:754:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/www/gunicorn_config.py:40:5: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ docs/exts/docs_build/spelling_checks.py:169:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ docs/exts/docs_build/spelling_checks.py:171:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/always/test_connection.py:687:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/models/test_dagbag.py:319:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1111:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1157:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1213:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1278:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1375:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1432:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1520:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1600:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1683:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_taskinstance.py:2061:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/alibaba/cloud/log/test_oss_task_handler.py:68:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/log/test_cloudwatch_task_handler.py:63:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/operators/test_eks.py:466:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/secrets/test_secrets_manager.py:379:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/secrets/test_systems_manager.py:195:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/common/sql/operators/test_sql.py:581:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/microsoft/azure/hooks/test_azure_data_lake.py:60:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/microsoft/azure/log/test_wasb_task_handler.py:81:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/system/providers/docker/example_docker_swarm.py:48:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/system/providers/elasticsearch/example_elasticsearch_query.py:78:9: B018 Found useless expression. Either assign it to a variable or remove it.

@charliermarsh
Copy link
Member Author

This is currently flagging statements like create_entry_group >> delete_entry_group which are effect-ful.

@charliermarsh charliermarsh force-pushed the charlie/useless-expression branch 2 times, most recently from 031b428 to aadef22 Compare March 12, 2023 05:14
@charliermarsh
Copy link
Member Author

We probably need to omit all BinOp due to operator overloading. I suppose we could flag BinOp where the types are constant.

@charliermarsh charliermarsh force-pushed the charlie/useless-expression branch 2 times, most recently from 860c631 to 3d11987 Compare March 12, 2023 05:17
@charliermarsh charliermarsh force-pushed the charlie/useless-expression branch 4 times, most recently from bd229c4 to 219f970 Compare March 12, 2023 23:54
@charliermarsh
Copy link
Member Author

I've been going back and forth on how aggressive to make this check. For example, should it flag expressions like:

x  # Name
x.y  # Attribute
[x for x in y]  # ListComp

Right now it does (though bugbear doesn't pick up any of them). Name seems like an obvious thing to pick up. But Attribute could be effectful though if you have a custom getter.

@smackesey - Any opinion here? I'm guessing you want to err on the side of being closer to Pylint, which would flag all of these :)

@smackesey
Copy link

IMO they should all be flagged. I realize "Attribute" and "ListComp" could be effectful, but there's really no good reason I can think of to write code where you rely on these unassigned expressions for side effects. They are much more likely to be unintended when they occur.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your PR summary to include documentation of what you changed: How does this PR fix the mentioned issue and does it fix all issues?

return;
}

// Ignore strings, to avoid false positives with docstrings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a small code snipped here of a case where a docstring causes a false positive would be helpful.

Is there a way to determine whether a string is a docstring?

Comment on lines +58 to +60
// Flag attributes as useless expressions, even if they're attached to calls or other
// expressions.
if matches!(value.node, ExprKind::Attribute { .. }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a different diagnostic in that case?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+357, -0, 0 error(s))

airflow (+35, -0)

+ airflow/providers/cncf/kubernetes/hooks/kubernetes.py:245:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/ftp/hooks/ftp.py:274:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/github/hooks/github.py:85:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_looker.py:63:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:423:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:428:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:583:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:638:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:710:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/providers/google/cloud/example_dags/example_vertex_ai.py:754:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ airflow/www/gunicorn_config.py:40:5: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ docs/exts/docs_build/spelling_checks.py:169:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ docs/exts/docs_build/spelling_checks.py:171:5: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/always/test_connection.py:687:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/models/test_dagbag.py:319:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1111:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1157:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1213:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1278:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1375:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1432:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1520:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1600:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_dagrun.py:1683:9: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/models/test_taskinstance.py:2061:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/alibaba/cloud/log/test_oss_task_handler.py:68:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/log/test_cloudwatch_task_handler.py:63:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/operators/test_eks.py:466:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/secrets/test_secrets_manager.py:379:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/amazon/aws/secrets/test_systems_manager.py:195:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/common/sql/operators/test_sql.py:581:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/microsoft/azure/hooks/test_azure_data_lake.py:60:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/providers/microsoft/azure/log/test_wasb_task_handler.py:81:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/system/providers/docker/example_docker_swarm.py:48:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/system/providers/elasticsearch/example_elasticsearch_query.py:78:9: B018 Found useless expression. Either assign it to a variable or remove it.

bokeh (+308, -0)

+ tests/codebase/test_code_quality.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_eslint.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_importlib_metadata.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_isort.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_js_license_set.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_json.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_license.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_client_server_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_ipython_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_pandas_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_request_host.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_selenium_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_tornado_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_no_typing_extensions_common.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_python_execution_with_OO.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_ruff.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/codebase/test_windows_reserved_filenames.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/embed/test_json_item.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/models/test_datarange1d.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/models/test_plot.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/models/test_sources.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/test_regressions.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_box_edit_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_box_zoom_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_custom_action.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_freehand_draw_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_pan_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_point_draw_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_poly_draw_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_poly_edit_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_range_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_reset_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_tap_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_wheel_pan_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_wheel_zoom_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_zoom_in_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/tools/test_zoom_out_tool.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_cell_editors.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_copy_paste.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_data_table.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_sortable.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/tables/test_source_updates.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_autocomplete_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_button.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_checkbox_button_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_checkbox_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_color_picker.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_copy_paste.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_datepicker.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_daterange_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_dateslider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_datetime_range_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_div.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_dropdown.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_multi_choice.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_numeric_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_paragraph.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_password_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_pretext.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_radio_button_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_radio_group.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_range_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_select.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_slider.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_spinner.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_text_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_textarea_input.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/integration/widgets/test_toggle.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_bokehjs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_defaults.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_examples.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/_testing/util/test_env.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test___init___handlers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_code.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_code_runner.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_directory.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_document_lifecycle.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_function.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_notebook__handlers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_script.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_server_lifecycle.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/handlers/test_server_request_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/test___init___application.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/application/test_application.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test___init___client.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_connection.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_session__client.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_states.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_util__client.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/client/test_websocket.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test___init___colors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_color__colors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_groups.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_named.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/colors/test_util__colors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test___init___subcommands.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_info.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_json__subcommands.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_sampledata__subcommands.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_secret.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/subcommands/test_serve.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test___init___command.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test_bootstrap.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test_subcommand.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/command/test_util__command.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/_util_property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test___init___property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_alias.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_aliases.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_any.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_auto.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_bases.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_color__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_container.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_dataspec.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_datetime.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptor_factory.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:110:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:111:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:112:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:113:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_descriptors.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_either.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_enum.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_include.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_instance.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_json__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_nullable.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_numeric.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_override.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_pd.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_primitive.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_required.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_singletons.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_string_properties.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_validation__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_vectorization.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_visual.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/property/test_wrappers__property.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_enums.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:121:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:126:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:131:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:136:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_has_props.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_json_encoder.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_properties.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_properties.py:367:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_properties.py:391:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_query.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_serialization.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_templates.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/core/test_validation.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/_util_document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_callbacks__document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_events__document.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_locking.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/document/test_modules.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test___init___embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_bundle.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_elements.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_notebook__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_server__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_standalone.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_util__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/embed/test_wrappers__embed.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test___init___io.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_export.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_notebook__io.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_output.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_saving.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_showing.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_state.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_util__io.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/io/test_webdriver.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test___init___model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_data_model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_docs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/model/test_util_model.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/_util_models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_annotations.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_axes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_callbacks__models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_defaults.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_dom.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_filters.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_formatters.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_glyph_renderer.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_glyphs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_glyphs.py:88:1: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_graph_renderer.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_graphs.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_grids.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_layouts__models.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_mappers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_plots.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_plots.py:491:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_ranges.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_sources.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_tools.py:14:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/test_transforms.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/util/test_structure.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:139:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:141:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:47:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:49:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:59:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:61:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:93:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/models/widgets/test_slider.py:95:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test___init___plotting.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__decorators.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__graph.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__legends.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__plot.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__renderer.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__stack.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test__tools.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test_contour.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test_figure.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/plotting/test_graph.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/messages/test_patch_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/messages/test_pull_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/messages/test_push_doc.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/test_message.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/protocol/test_receiver.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test___init___sampledata.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_airport_routes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_airports.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_anscombe.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_antibiotics.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_autompg.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_autompg2.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_browsers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_commits.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_daylight.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_degrees.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_gapminder.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_glucose.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_haar_cascade.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_iris.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_les_mis.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_movies_data.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_mtb.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_olympics2014.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_perceptions.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_periodic_table.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_population.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sample_geojson.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sample_superstore.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sea_surface_temperature.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_sprint.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_stocks.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_unemployment.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_unemployment1948.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_cities.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_counties.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_holidays.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_marriages_divorces.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_us_states.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/sampledata/test_world_cities.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_auth_provider.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_callbacks__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_contexts.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_server__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_session__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_tornado__server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/test_util.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_metadata_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_root_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_session_handler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/server/views/test_ws.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test___init__.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test___main__.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_client_server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_driving.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_events.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_ext.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_layouts.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_objects.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_palettes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_server.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_settings.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_themes.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_tile_providers.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/test_transform.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_browser.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_callback_manager.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_compiler.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_dataclasses.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_dependencies.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_deprecation.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_hex.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_options.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_package.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_sampledata__util.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_strings.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_token.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_tornado__util.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_util__serialization.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_version.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/unit/bokeh/util/test_warnings.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.

build (+1, -0)

+ tests/test_self_packaging.py:49:5: B018 Found useless attribute access. Either assign it to a variable or remove it.

disnake (+11, -0)

+ disnake/ext/commands/context.py:351:13: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/test_embeds.py:482:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:103:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:104:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:106:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:75:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:76:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:78:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:89:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:90:13: B018 Found useless attribute access. Either assign it to a variable or remove it.
+ tests/ui/test_action_row.py:92:13: B018 Found useless attribute access. Either assign it to a variable or remove it.

zulip (+2, -0)

+ zerver/apps.py:32:9: B018 Found useless expression. Either assign it to a variable or remove it.
+ zerver/views/realm.py:185:5: B018 Found useless expression. Either assign it to a variable or remove it.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     17.3±0.89ms     2.4 MB/sec    1.05     18.2±0.68ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.3±0.16ms     3.9 MB/sec    1.08      4.6±0.18ms     3.6 MB/sec
linter/all-rules/numpy/globals.py          1.00   613.0±23.37µs     4.8 MB/sec    1.03   629.4±29.00µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.5±0.21ms     3.4 MB/sec    1.03      7.7±0.58ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.02      9.0±0.24ms     4.5 MB/sec    1.00      8.9±0.19ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.0±0.06ms     8.2 MB/sec    1.00      2.0±0.12ms     8.2 MB/sec
linter/default-rules/numpy/globals.py      1.04   260.7±16.85µs    11.3 MB/sec    1.00    249.9±9.11µs    11.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.5±0.20ms     5.7 MB/sec    1.05      4.7±0.23ms     5.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     19.4±0.52ms     2.1 MB/sec    1.00     19.4±0.51ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.2±0.13ms     3.2 MB/sec    1.00      5.2±0.15ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   663.0±35.16µs     4.5 MB/sec    1.00   660.1±26.77µs     4.5 MB/sec
linter/all-rules/pydantic/types.py         1.01      8.5±0.24ms     3.0 MB/sec    1.00      8.4±0.18ms     3.0 MB/sec
linter/default-rules/large/dataset.py      1.00     10.3±0.23ms     3.9 MB/sec    1.00     10.3±0.22ms     3.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01      2.3±0.08ms     7.3 MB/sec    1.00      2.2±0.06ms     7.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    260.9±6.25µs    11.3 MB/sec    1.04   270.2±13.12µs    10.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.8±0.10ms     5.3 MB/sec    1.02      4.9±0.17ms     5.2 MB/sec

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Mar 17, 2023
@henryiii
Copy link
Contributor

The one in build is useless, certainly! :)

@charliermarsh charliermarsh merged commit e8d17d2 into main Mar 23, 2023
@charliermarsh charliermarsh deleted the charlie/useless-expression branch March 23, 2023 22:34
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Mar 30, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.259` ->
`^0.0.260` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/compatibility-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/confidence-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Rules

- \[`flake8-bugbear`] Add more immutable functions for `B008` by
[@&#8203;rouge8](https://togithub.com/rouge8) in
[astral-sh/ruff#3764
- \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by
[@&#8203;rouge8](https://togithub.com/rouge8) in
[astral-sh/ruff#3794
- \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3455
- \[`flake8-bugbear`]: Implement rule `B031` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3680
- \[`flake8-gettext`] Implement `flake8-gettext` by
[@&#8203;leiserfg](https://togithub.com/leiserfg) in
[astral-sh/ruff#3785
- \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in
`flake8-logging-format` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3726
- \[`flake8-logging-format`] Allow aliased `logging` module as a logger
candidate by [@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3718
- \[`flake8-pyi`] Add autofix for `PYI014` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3729
- \[`flake8-pyi`] Implement `PYI012` by
[@&#8203;JBLDKY](https://togithub.com/JBLDKY) in
[astral-sh/ruff#3743
- \[`flake8-pyi`] Implement `PYI015` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3728
- \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3740
- \[`isort`]: support submodules in known\_(first|third)\_party config
options by [@&#8203;astaric](https://togithub.com/astaric) in
[astral-sh/ruff#3768
- \[`pycodestyle`] Use unicode-width to determine line-length instead of
character count by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#3714
- \[`pydocstyle`] Implement autofix for `D403` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3731
- \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3761
- \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3705
- \[`tryceratops`] Exempt return with side effects for TRY300 by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3780

##### Bug Fixes

- Avoid parsing `ForwardRef` contents as type references by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3698
- Avoid parsing f-strings in type annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3699
- Include `with` statements in complexity calculation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3771
- Use import alias locations for `pep8-naming` import rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3772
- Allow `TID252` to fix all valid module paths by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3796
- Fix SIM118 auto-fix by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3695
- Avoid panics for implicitly concatenated forward references by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3700
- Allow simple container literals as default values by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3703
- Traverse over nested string type annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3724
- Use `wild::args()` and add `wild` as a dependency by
[@&#8203;agriyakhetarpal](https://togithub.com/agriyakhetarpal) in
[astral-sh/ruff#3739
- Avoid overlong-line errors for lines that end with URLs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3663
- Sort statistics by count by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3748
- Reduce explicit clones by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#3793
- Add flymake-ruff to docs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3800

#### New Contributors

- [@&#8203;agriyakhetarpal](https://togithub.com/agriyakhetarpal) made
their first contribution in
[astral-sh/ruff#3739
- [@&#8203;leiserfg](https://togithub.com/leiserfg) made their first
contribution in
[astral-sh/ruff#3741
- [@&#8203;JBLDKY](https://togithub.com/JBLDKY) made their first
contribution in
[astral-sh/ruff#3743
- [@&#8203;astaric](https://togithub.com/astaric) made their first
contribution in
[astral-sh/ruff#3768

**Full Changelog**:
astral-sh/ruff@v0.0.259...v0.0.260

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMi4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjIuMSJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to allenporter/pyrainbird that referenced this pull request Mar 31, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.259` ->
`==0.0.260` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/compatibility-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/confidence-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Rules

- \[`flake8-bugbear`] Add more immutable functions for `B008` by
[@&#8203;rouge8](https://togithub.com/rouge8) in
[astral-sh/ruff#3764
- \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by
[@&#8203;rouge8](https://togithub.com/rouge8) in
[astral-sh/ruff#3794
- \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3455
- \[`flake8-bugbear`]: Implement rule `B031` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3680
- \[`flake8-gettext`] Implement `flake8-gettext` by
[@&#8203;leiserfg](https://togithub.com/leiserfg) in
[astral-sh/ruff#3785
- \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in
`flake8-logging-format` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3726
- \[`flake8-logging-format`] Allow aliased `logging` module as a logger
candidate by [@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3718
- \[`flake8-pyi`] Add autofix for `PYI014` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3729
- \[`flake8-pyi`] Implement `PYI012` by
[@&#8203;JBLDKY](https://togithub.com/JBLDKY) in
[astral-sh/ruff#3743
- \[`flake8-pyi`] Implement `PYI015` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3728
- \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3740
- \[`isort`]: support submodules in known\_(first|third)\_party config
options by [@&#8203;astaric](https://togithub.com/astaric) in
[astral-sh/ruff#3768
- \[`pycodestyle`] Use unicode-width to determine line-length instead of
character count by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#3714
- \[`pydocstyle`] Implement autofix for `D403` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3731
- \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3761
- \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3705
- \[`tryceratops`] Exempt return with side effects for TRY300 by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3780

##### Bug Fixes

- Avoid parsing `ForwardRef` contents as type references by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3698
- Avoid parsing f-strings in type annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3699
- Include `with` statements in complexity calculation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3771
- Use import alias locations for `pep8-naming` import rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3772
- Allow `TID252` to fix all valid module paths by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3796
- Fix SIM118 auto-fix by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3695
- Avoid panics for implicitly concatenated forward references by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3700
- Allow simple container literals as default values by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3703
- Traverse over nested string type annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3724
- Use `wild::args()` and add `wild` as a dependency by
[@&#8203;agriyakhetarpal](https://togithub.com/agriyakhetarpal) in
[astral-sh/ruff#3739
- Avoid overlong-line errors for lines that end with URLs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3663
- Sort statistics by count by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3748
- Reduce explicit clones by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#3793
- Add flymake-ruff to docs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3800

#### New Contributors

- [@&#8203;agriyakhetarpal](https://togithub.com/agriyakhetarpal) made
their first contribution in
[astral-sh/ruff#3739
- [@&#8203;leiserfg](https://togithub.com/leiserfg) made their first
contribution in
[astral-sh/ruff#3741
- [@&#8203;JBLDKY](https://togithub.com/JBLDKY) made their first
contribution in
[astral-sh/ruff#3743
- [@&#8203;astaric](https://togithub.com/astaric) made their first
contribution in
[astral-sh/ruff#3768

**Full Changelog**:
astral-sh/ruff@v0.0.259...v0.0.260

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMy4zIiwidXBkYXRlZEluVmVyIjoiMzUuMjMuMyJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@AA-Turner AA-Turner mentioned this pull request Mar 31, 2023
renovate bot added a commit to allenporter/flux-local that referenced this pull request Apr 1, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.259` ->
`==0.0.260` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/compatibility-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/confidence-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Rules

- \[`flake8-bugbear`] Add more immutable functions for `B008` by
[@&#8203;rouge8](https://togithub.com/rouge8) in
[astral-sh/ruff#3764
- \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by
[@&#8203;rouge8](https://togithub.com/rouge8) in
[astral-sh/ruff#3794
- \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3455
- \[`flake8-bugbear`]: Implement rule `B031` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3680
- \[`flake8-gettext`] Implement `flake8-gettext` by
[@&#8203;leiserfg](https://togithub.com/leiserfg) in
[astral-sh/ruff#3785
- \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in
`flake8-logging-format` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3726
- \[`flake8-logging-format`] Allow aliased `logging` module as a logger
candidate by [@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#3718
- \[`flake8-pyi`] Add autofix for `PYI014` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3729
- \[`flake8-pyi`] Implement `PYI012` by
[@&#8203;JBLDKY](https://togithub.com/JBLDKY) in
[astral-sh/ruff#3743
- \[`flake8-pyi`] Implement `PYI015` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3728
- \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3740
- \[`isort`]: support submodules in known\_(first|third)\_party config
options by [@&#8203;astaric](https://togithub.com/astaric) in
[astral-sh/ruff#3768
- \[`pycodestyle`] Use unicode-width to determine line-length instead of
character count by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#3714
- \[`pydocstyle`] Implement autofix for `D403` by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3731
- \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3761
- \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3705
- \[`tryceratops`] Exempt return with side effects for TRY300 by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3780

##### Bug Fixes

- Avoid parsing `ForwardRef` contents as type references by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3698
- Avoid parsing f-strings in type annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3699
- Include `with` statements in complexity calculation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3771
- Use import alias locations for `pep8-naming` import rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3772
- Allow `TID252` to fix all valid module paths by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3796
- Fix SIM118 auto-fix by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3695
- Avoid panics for implicitly concatenated forward references by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3700
- Allow simple container literals as default values by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3703
- Traverse over nested string type annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3724
- Use `wild::args()` and add `wild` as a dependency by
[@&#8203;agriyakhetarpal](https://togithub.com/agriyakhetarpal) in
[astral-sh/ruff#3739
- Avoid overlong-line errors for lines that end with URLs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3663
- Sort statistics by count by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#3748
- Reduce explicit clones by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#3793
- Add flymake-ruff to docs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#3800

#### New Contributors

- [@&#8203;agriyakhetarpal](https://togithub.com/agriyakhetarpal) made
their first contribution in
[astral-sh/ruff#3739
- [@&#8203;leiserfg](https://togithub.com/leiserfg) made their first
contribution in
[astral-sh/ruff#3741
- [@&#8203;JBLDKY](https://togithub.com/JBLDKY) made their first
contribution in
[astral-sh/ruff#3743
- [@&#8203;astaric](https://togithub.com/astaric) made their first
contribution in
[astral-sh/ruff#3768

**Full Changelog**:
astral-sh/ruff@v0.0.259...v0.0.260

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMi4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjIuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug?] B018 useless-expression does not work
4 participants