Use unicode-width to determine line-length instead of character count

[MichaReiser]

This PR changes the logic testing if a line exceeds the configured line-width to use the unicode-width rather than character count.

Changing this breaks compatibility with pycodestyle because they decided to stick with ASCII width (because PEP8 recommends ASCII source code). I think its worth diverging from pycodestyle because our formatter uses unicode width and black is adopting too

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Use unicode-width to determine line-length instead of character count #3714 👈
    • PR perf(pycodestyle): Reduce allocations when computing logical lines #3715
      • PR perf(pycodestyle): Remove regex captures #3735
        • PR perf(pycodestyle): Refactor checks to iterate over tokens insteadof text #3736
          • PR perf(pycodestyle): Introduce TokenKind #3745
            • PR perf(pycodestyle): Initialize Stylist from tokens #3757
          • PR Token Kind, remove text #3737

This comment was auto-generated by Graphite.

[github-actions]

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+6, -4, 0 error(s))

zulip (+6, -4)

- zerver/tests/test_message_fetch.py:2262:101: E501 Line too long (106 > 100 characters)
+ zerver/tests/test_message_fetch.py:2262:101: E501 Line too long (123 > 100 characters)
+ zerver/tests/test_message_fetch.py:2430:101: E501 Line too long (110 > 100 characters)
+ zerver/webhooks/slack_incoming/tests.py:149:101: E501 Line too long (191 > 100 characters)
- zerver/webhooks/slack_incoming/tests.py:149:101: E501 Line too long (193 > 100 characters)
+ zerver/webhooks/slack_incoming/tests.py:151:101: E501 Line too long (217 > 100 characters)
- zerver/webhooks/slack_incoming/tests.py:151:101: E501 Line too long (219 > 100 characters)
- zerver/webhooks/slack_incoming/tests.py:155:101: E501 Line too long (210 > 100 characters)
+ zerver/webhooks/slack_incoming/tests.py:155:101: E501 Line too long (211 > 100 characters)
+ zilencer/management/commands/populate_db.py:873:101: E501 Line too long (106 > 100 characters)

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.1±0.06ms     2.9 MB/sec    1.02     14.4±0.04ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.8±0.01ms     4.4 MB/sec    1.00      3.8±0.00ms     4.4 MB/sec
linter/all-rules/numpy/globals.py          1.00    434.1±2.12µs     6.8 MB/sec    1.01    436.4±1.79µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.3±0.02ms     4.1 MB/sec    1.01      6.4±0.04ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.00      7.7±0.06ms     5.3 MB/sec    1.03      7.9±0.07ms     5.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1705.2±6.85µs     9.8 MB/sec    1.01   1715.6±3.04µs     9.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    176.1±0.45µs    16.8 MB/sec    1.03    181.0±7.58µs    16.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.01ms     7.0 MB/sec    1.02      3.7±0.00ms     6.9 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.04     19.3±0.37ms     2.1 MB/sec    1.00     18.6±0.35ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.05      5.2±0.08ms     3.2 MB/sec    1.00      4.9±0.07ms     3.4 MB/sec
linter/all-rules/numpy/globals.py          1.02   647.5±15.12µs     4.6 MB/sec    1.00   632.7±16.99µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.04      8.5±0.14ms     3.0 MB/sec    1.00      8.2±0.12ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.08     10.6±0.14ms     3.8 MB/sec    1.00      9.8±0.17ms     4.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.08      2.4±0.17ms     7.1 MB/sec    1.00      2.2±0.07ms     7.6 MB/sec
linter/default-rules/numpy/globals.py      1.04    267.4±8.93µs    11.0 MB/sec    1.00   256.9±10.63µs    11.5 MB/sec
linter/default-rules/pydantic/types.py     1.07      4.9±0.14ms     5.2 MB/sec    1.00      4.6±0.11ms     5.6 MB/sec