perf(logical-lines): Various small perf improvements

[MichaReiser]

This PR introduces a few perf improvements to the pycodestyle rules:

• Introduce a new LogicalLinesContext to which rules add their diagnostics directly. This reduces the need to copy Diagnostics between different Vecs.
• Avoid using Option<T> where we can instead use TextSize::default or Tok::EndOfFile. This reduces the required branching.
• extraneous_whitespace: Move the DiagnosticKind::from closer to where we create the Diagnostic to avoid unnecessary allocations and message formatting in case the code is valid
• LogicalLines: Use a Slice instead of a struct of vecs. Both implementations have roughly the same performance but using a Slice requires significantly less code.
• LineIndex: Replace TextSize::try_from with a single assertion on the length of the string. We call this function so often that it shows up in traces. Using TextSize::new(x as u32) removes that slight overhead.

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Add parser benchmark #3990
    • PR Replace row/column based Location with byte-offsets. #3931
      • PR Use memchr to speedup newline search on x86 #3985
      • PR perf(logical-lines): Various small perf improvements #4022 👈
        • PR Use iter for logical lines #4120
      • PR Replace LexResult with Tok::Error #4121

This comment was auto-generated by Graphite.

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     14.9±0.15ms     2.7 MB/sec    1.00     14.7±0.05ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.6±0.01ms     4.6 MB/sec    1.00      3.6±0.13ms     4.6 MB/sec
linter/all-rules/numpy/globals.py          1.01    381.1±5.66µs     7.7 MB/sec    1.00    378.3±1.71µs     7.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.2±0.02ms     4.1 MB/sec    1.00      6.2±0.01ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.01      7.6±0.11ms     5.3 MB/sec    1.00      7.6±0.01ms     5.4 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1596.4±2.47µs    10.4 MB/sec    1.00   1594.5±5.73µs    10.4 MB/sec
linter/default-rules/numpy/globals.py      1.01    175.7±0.34µs    16.8 MB/sec    1.00    173.7±0.69µs    17.0 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.4±0.01ms     7.5 MB/sec    1.00      3.4±0.01ms     7.5 MB/sec
parser/large/dataset.py                    1.00      5.9±0.01ms     6.9 MB/sec    1.00      5.9±0.02ms     6.9 MB/sec
parser/numpy/ctypeslib.py                  1.00   1147.6±1.69µs    14.5 MB/sec    1.00   1146.9±1.60µs    14.5 MB/sec
parser/numpy/globals.py                    1.00    116.6±0.28µs    25.3 MB/sec    1.00    116.4±0.69µs    25.3 MB/sec
parser/pydantic/types.py                   1.00      2.5±0.00ms    10.2 MB/sec    1.00      2.5±0.06ms    10.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     20.5±0.48ms  2028.4 KB/sec    1.01     20.8±0.60ms  2002.6 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      5.3±0.13ms     3.1 MB/sec    1.00      5.3±0.16ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   626.3±15.49µs     4.7 MB/sec    1.00   625.7±16.55µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.8±0.30ms     2.9 MB/sec    1.01      8.8±0.22ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.00     10.3±0.19ms     3.9 MB/sec    1.03     10.7±0.26ms     3.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01      2.3±0.13ms     7.4 MB/sec    1.00      2.2±0.06ms     7.5 MB/sec
linter/default-rules/numpy/globals.py      1.00   266.5±12.18µs    11.1 MB/sec    1.03   275.1±12.51µs    10.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.7±0.09ms     5.4 MB/sec    1.02      4.8±0.12ms     5.3 MB/sec
parser/large/dataset.py                    1.00      8.5±0.47ms     4.8 MB/sec    1.01      8.6±0.14ms     4.8 MB/sec
parser/numpy/ctypeslib.py                  1.00  1599.9±39.65µs    10.4 MB/sec    1.04  1659.6±29.99µs    10.0 MB/sec
parser/numpy/globals.py                    1.00   165.2±11.41µs    17.9 MB/sec    1.01    166.4±6.66µs    17.7 MB/sec
parser/pydantic/types.py                   1.00      3.6±0.08ms     7.0 MB/sec    1.01      3.7±0.07ms     7.0 MB/sec