Fix `E713` and `E714` false positives for multiple comparisons #4083

JonathanPlasse · 2023-04-24T19:47:58Z

Close E714 Complex logic handling #4082

github-actions · 2023-04-24T19:59:04Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     19.8±0.70ms     2.1 MB/sec    1.00     19.7±0.50ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.8±0.14ms     3.5 MB/sec    1.00      4.8±0.11ms     3.5 MB/sec
linter/all-rules/numpy/globals.py          1.00   619.0±27.29µs     4.8 MB/sec    1.04   646.2±41.10µs     4.6 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.3±0.28ms     3.1 MB/sec    1.01      8.3±0.30ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.02     10.1±0.29ms     4.0 MB/sec    1.00      9.8±0.22ms     4.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02      2.2±0.07ms     7.4 MB/sec    1.00      2.2±0.05ms     7.6 MB/sec
linter/default-rules/numpy/globals.py      1.00   269.1±10.95µs    11.0 MB/sec    1.00   268.6±11.70µs    11.0 MB/sec
linter/default-rules/pydantic/types.py     1.03      4.6±0.13ms     5.5 MB/sec    1.00      4.5±0.13ms     5.7 MB/sec
parser/large/dataset.py                    1.01      8.1±0.35ms     5.0 MB/sec    1.00      8.0±0.19ms     5.1 MB/sec
parser/numpy/ctypeslib.py                  1.00  1550.3±53.24µs    10.7 MB/sec    1.03  1596.3±49.16µs    10.4 MB/sec
parser/numpy/globals.py                    1.02    162.1±7.19µs    18.2 MB/sec    1.00    159.3±5.61µs    18.5 MB/sec
parser/pydantic/types.py                   1.02      3.6±0.18ms     7.2 MB/sec    1.00      3.5±0.15ms     7.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     17.2±0.25ms     2.4 MB/sec    1.02     17.4±0.32ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.5±0.07ms     3.7 MB/sec    1.01      4.5±0.09ms     3.7 MB/sec
linter/all-rules/numpy/globals.py          1.01    550.3±9.05µs     5.4 MB/sec    1.00   547.3±10.63µs     5.4 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.3±0.11ms     3.5 MB/sec    1.00      7.3±0.10ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.02      9.1±0.16ms     4.5 MB/sec    1.00      8.9±0.15ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02  1967.3±27.26µs     8.5 MB/sec    1.00  1925.8±21.02µs     8.6 MB/sec
linter/default-rules/numpy/globals.py      1.01    223.8±6.52µs    13.2 MB/sec    1.00    222.6±8.29µs    13.3 MB/sec
linter/default-rules/pydantic/types.py     1.01      4.1±0.08ms     6.2 MB/sec    1.00      4.1±0.08ms     6.3 MB/sec
parser/large/dataset.py                    1.00      6.9±0.05ms     5.9 MB/sec    1.00      6.9±0.05ms     5.9 MB/sec
parser/numpy/ctypeslib.py                  1.01  1317.5±12.11µs    12.6 MB/sec    1.00  1303.3±15.29µs    12.8 MB/sec
parser/numpy/globals.py                    1.00    131.2±1.44µs    22.5 MB/sec    1.01    132.0±1.98µs    22.3 MB/sec
parser/pydantic/types.py                   1.00      3.0±0.03ms     8.6 MB/sec    1.02      3.0±0.05ms     8.5 MB/sec

charliermarsh · 2023-04-25T00:13:09Z

crates/ruff/resources/test/fixtures/pycodestyle/E714.py

@@ -4,11 +4,11 @@
 #: E714
 if not X.B is Y:
    pass
-#: E714
+
+#: Okay
 if not X is Y is not Z:


I feel like this one is arguably a false negative, what do you think?

How would you rewrite it?

Yeah, I guess you're right -- I have no idea 😂

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.263` -> `^0.0.264` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/compatibility-slim/0.0.263)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/confidence-slim/0.0.263)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.264`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.264) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.263...v0.0.264)  #### What's Changed ##### Rules - Autofix `EM101`, `EM102`, `EM103` if possible by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4123 - Add bugbear immutable functions as allowed in dataclasses by [@mosauter](https://togithub.com/mosauter) in [astral-sh/ruff#4122 ##### Settings - Add support for providing command-line arguments via `argfile` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4087 ##### Bug Fixes - Make D410/D411 autofixes mutually exclusive by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4110 - Remove `pyright` comment prefix from PYI033 checks by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4152 - Fix F811 false positive with match by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4161 - Fix `E713` and `E714` false positives for multiple comparisons by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4083 - Fix B023 shadowed variables in nested functions by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4111 - Preserve star-handling special-casing for force-single-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4129 - Respect parent-scoping rules for `NamedExpr` assignments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4145 - Fix UP032 auto-fix by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4165 - Allow boolean parameters for `pytest.param` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4176 ##### Internal - Replace row/column based `Location` with byte-offsets. by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3931 - perf(logical-lines): Various small perf improvements by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4022 - Use `memchr` to speedup newline search on x86 by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3985 - Remove `ScopeStack` in favor of child-parent `ScopeId` pointers by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4138 **Full Changelog**: astral-sh/ruff@v0.0.263...v0.0.264 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.263` -> `==0.0.264` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/compatibility-slim/0.0.263)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/confidence-slim/0.0.263)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.264`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.264) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.263...v0.0.264)  #### What's Changed ##### Rules - Autofix `EM101`, `EM102`, `EM103` if possible by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4123 - Add bugbear immutable functions as allowed in dataclasses by [@mosauter](https://togithub.com/mosauter) in [astral-sh/ruff#4122 ##### Settings - Add support for providing command-line arguments via `argfile` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4087 ##### Bug Fixes - Make D410/D411 autofixes mutually exclusive by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4110 - Remove `pyright` comment prefix from PYI033 checks by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4152 - Fix F811 false positive with match by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4161 - Fix `E713` and `E714` false positives for multiple comparisons by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4083 - Fix B023 shadowed variables in nested functions by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4111 - Preserve star-handling special-casing for force-single-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4129 - Respect parent-scoping rules for `NamedExpr` assignments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4145 - Fix UP032 auto-fix by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4165 - Allow boolean parameters for `pytest.param` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4176 ##### Internal - Replace row/column based `Location` with byte-offsets. by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3931 - perf(logical-lines): Various small perf improvements by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4022 - Use `memchr` to speedup newline search on x86 by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3985 - Remove `ScopeStack` in favor of child-parent `ScopeId` pointers by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4138 **Full Changelog**: astral-sh/ruff@v0.0.263...v0.0.264 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.263` -> `==0.0.264` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/compatibility-slim/0.0.263)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.264/confidence-slim/0.0.263)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.264`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.264) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.263...v0.0.264)  #### What's Changed ##### Rules - Autofix `EM101`, `EM102`, `EM103` if possible by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4123 - Add bugbear immutable functions as allowed in dataclasses by [@mosauter](https://togithub.com/mosauter) in [astral-sh/ruff#4122 ##### Settings - Add support for providing command-line arguments via `argfile` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4087 ##### Bug Fixes - Make D410/D411 autofixes mutually exclusive by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4110 - Remove `pyright` comment prefix from PYI033 checks by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4152 - Fix F811 false positive with match by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4161 - Fix `E713` and `E714` false positives for multiple comparisons by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4083 - Fix B023 shadowed variables in nested functions by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4111 - Preserve star-handling special-casing for force-single-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4129 - Respect parent-scoping rules for `NamedExpr` assignments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4145 - Fix UP032 auto-fix by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4165 - Allow boolean parameters for `pytest.param` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4176 ##### Internal - Replace row/column based `Location` with byte-offsets. by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3931 - perf(logical-lines): Various small perf improvements by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4022 - Use `memchr` to speedup newline search on x86 by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3985 - Remove `ScopeStack` in favor of child-parent `ScopeId` pointers by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4138 **Full Changelog**: astral-sh/ruff@v0.0.263...v0.0.264 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Fix E713 and E714 false positive

bfb2a90

charliermarsh reviewed Apr 25, 2023

View reviewed changes

charliermarsh changed the title ~~Fix E713 and E714 false positive~~ Fix E713 and E714 false positives for multiple comparisons Apr 25, 2023

charliermarsh merged commit 4df7bc0 into astral-sh:main Apr 25, 2023
14 checks passed

JonathanPlasse deleted the fix-e713-a714-false-positive branch April 25, 2023 17:44

Tenzer mentioned this pull request May 2, 2023

ruff 0.0.264 Homebrew/homebrew-core#129929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `E713` and `E714` false positives for multiple comparisons #4083

Fix `E713` and `E714` false positives for multiple comparisons #4083

JonathanPlasse commented Apr 24, 2023

github-actions bot commented Apr 24, 2023 •

edited

charliermarsh Apr 25, 2023

JonathanPlasse Apr 25, 2023

charliermarsh Apr 25, 2023

Fix E713 and E714 false positives for multiple comparisons #4083

Fix E713 and E714 false positives for multiple comparisons #4083

Conversation

JonathanPlasse commented Apr 24, 2023

github-actions bot commented Apr 24, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh Apr 25, 2023

Choose a reason for hiding this comment

JonathanPlasse Apr 25, 2023

Choose a reason for hiding this comment

charliermarsh Apr 25, 2023

Choose a reason for hiding this comment

Fix `E713` and `E714` false positives for multiple comparisons #4083

Fix `E713` and `E714` false positives for multiple comparisons #4083

github-actions bot commented Apr 24, 2023 •

edited