Avoid fixing `PD002` in a lambda expression #4286

dhruvmanila · 2023-05-08T14:58:49Z

github-actions · 2023-05-08T15:11:41Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.02     14.1±0.03ms     2.9 MB/sec    1.00     13.8±0.03ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      3.4±0.01ms     4.9 MB/sec    1.00      3.3±0.00ms     5.0 MB/sec
linter/all-rules/numpy/globals.py          1.01    418.8±1.50µs     7.0 MB/sec    1.00    414.9±0.92µs     7.1 MB/sec
linter/all-rules/pydantic/types.py         1.02      5.9±0.01ms     4.3 MB/sec    1.00      5.8±0.01ms     4.4 MB/sec
linter/default-rules/large/dataset.py      1.02      7.0±0.04ms     5.8 MB/sec    1.00      6.8±0.01ms     5.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02  1505.2±10.11µs    11.1 MB/sec    1.00   1479.4±2.92µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.01   164.3±10.11µs    18.0 MB/sec    1.00    162.5±0.23µs    18.2 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.1±0.01ms     8.2 MB/sec    1.00      3.1±0.01ms     8.3 MB/sec
parser/large/dataset.py                    1.00      5.4±0.01ms     7.5 MB/sec    1.01      5.5±0.00ms     7.5 MB/sec
parser/numpy/ctypeslib.py                  1.00   1053.9±0.69µs    15.8 MB/sec    1.01   1060.4±1.34µs    15.7 MB/sec
parser/numpy/globals.py                    1.00    106.8±0.27µs    27.6 MB/sec    1.00    107.3±0.16µs    27.5 MB/sec
parser/pydantic/types.py                   1.00      2.3±0.01ms    11.0 MB/sec    1.00      2.3±0.00ms    11.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.4±0.05ms     2.5 MB/sec    1.01     16.6±0.10ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.3±0.17ms     3.9 MB/sec    1.00      4.2±0.04ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.01    432.5±6.44µs     6.8 MB/sec    1.00    429.6±5.05µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.09ms     3.6 MB/sec    1.00      7.1±0.04ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.5±0.05ms     4.8 MB/sec    1.00      8.5±0.08ms     4.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1781.2±19.21µs     9.3 MB/sec    1.01   1793.2±9.39µs     9.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    191.6±2.51µs    15.4 MB/sec    1.01    192.5±3.46µs    15.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.8±0.04ms     6.7 MB/sec    1.00      3.8±0.02ms     6.7 MB/sec
parser/large/dataset.py                    1.00      6.7±0.02ms     6.0 MB/sec    1.04      7.0±0.06ms     5.8 MB/sec
parser/numpy/ctypeslib.py                  1.00   1285.0±7.42µs    13.0 MB/sec    1.03   1320.7±8.85µs    12.6 MB/sec
parser/numpy/globals.py                    1.00    133.0±1.26µs    22.2 MB/sec    1.01    134.6±1.12µs    21.9 MB/sec
parser/pydantic/types.py                   1.00      2.8±0.02ms     9.0 MB/sec    1.03      2.9±0.01ms     8.7 MB/sec

charliermarsh · 2023-05-08T18:10:10Z

crates/ruff/src/rules/pandas_vet/rules/inplace_argument.rs

                let fixable = !seen_star
                    && matches!(checker.ctx.current_stmt().node, StmtKind::Expr { .. })
-                    && checker.ctx.current_expr_parent().is_none();
+                    && checker.ctx.current_expr_parent().is_none()
+                    && !checker.ctx.scope().kind.is_lambda();


Ah yeah, the existing checks actually should catch this, but it has to do with a limitation in the context we "restore" when parsing deferred bodies (like lambda bodies). In short, we don't restore the expression stack, since it's expensive to track all expressions, and I hadn't realized it was necessary, but it is here.

I'll add a TODO and merge.

Ah right. I wondered why (2) was not catching it but didn't have time to dig deeper 😅

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.265` -> `^0.0.267` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/compatibility-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/confidence-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.267`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.267) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.266...v0.0.267)  #### Summary Follow-up release to v0.0.266 to fix an issue with `python -m ruff`- and `import ruff`-based workflows. (No new rules or functionality.) #### What's Changed ##### Rules - Implement `RUF010` to detect explicit type conversions within f-strings by [@LotemAm](https://togithub.com/LotemAm) in [astral-sh/ruff#4387 ##### Other Changes - Workaround for maturin bug by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4399 #### New Contributors - [@OMEGARAZER](https://togithub.com/OMEGARAZER) made their first contribution in [astral-sh/ruff#3938 - [@LotemAm](https://togithub.com/LotemAm) made their first contribution in [astral-sh/ruff#4387 **Full Changelog**: astral-sh/ruff@v0.0.266...v0.0.267 ### [`v0.0.266`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.266) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.265...v0.0.266)  #### What's Changed ##### Breaking Changes - Remove deprecated `update-check` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4313 - JSON Emitter: Use one indexed column numbers for edits by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4007 ##### Rules - \[`pygrep-hooks`] Implement pygrep-hook's Mock-mistake diagnostic by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4366 - \[`pylint`] Implement `nested-min-max` (`W3301`) by [@mccullocht](https://togithub.com/mccullocht) in [astral-sh/ruff#4200 - \[`flynt`] Implement Flynt static string join transform as FLY002 by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4196 - \[`pylint`] Include positional- and keyword-only arguments in too-many-arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4329 - \[`ruff`] Update confusable character mapping by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4274 ##### Settings - Add .git-rewrite folder to default ignored folder paths by [@jleclanche](https://togithub.com/jleclanche) in [astral-sh/ruff#4261 - Feat: detect changes also in configuration files by [@mikeleppane](https://togithub.com/mikeleppane) in [astral-sh/ruff#4169 ##### Bug Fixes - Revert the B027 autofix logic by [@aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4310 - Consider Flask app logger as logger candidate by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4253 - Enforce max-doc-length for multi-line docstrings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4347 - Avoid re-using imports beyond current edit site by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4378 - Respect insertion location when importing symbols by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4258 - Fix jemalloc page size on aarch64 by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4247 - Fix replace_whitespace() tabulation to space by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4226 - Avoid fixing `PD002` in a lambda expression by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4286 - Avoid `D403` if first char cannot be uppercased by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4283 - Avoid panics for f-string rewrites at start-of-file by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4291 - Rewrite `not not a` as `bool(a)` in boolean contexts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4294 - Include static and class methods in in abstract decorator list by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4298 - Specify exact command in incorrect parentheses suggestion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4300 - Ignore `TRY301` exceptions without except handlers by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4301 - Preserve whitespace around `ListComp` brackets in `C419` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4099 - Tweak capitalization of B021 message by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4350 - Avoid debug panic with empty indent replacement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4364 - Use target name in hardcoded-password diagnostics by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4365 - Avoid underflow in expected-special-method-signature by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4377 - Respect `__all__` imports when determining definition visibility by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4357 - Ignore some methods on list in `flake8-boolean-trap` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4385 - Fix false positives in PD002 by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4337 - Run autofix on initial watcher pass by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4311 - Avoid SIM105 autofixes that would remove comments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4330 - Handle `.encode` calls on parenthesized expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4338 - Truncate `SyntaxError`s before newline character by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4124 - Use non-empty ranges for logical-lines diagnostics by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4133 #### New Contributors - [@jleclanche](https://togithub.com/jleclanche) made their first contribution in [astral-sh/ruff#4261 - [@aureliojargas](https://togithub.com/aureliojargas) made their first contribution in [astral-sh/ruff#4306 - [@intgr](https://togithub.com/intgr) made their first contribution in [astral-sh/ruff#4304 - [@mikeleppane](https://togithub.com/mikeleppane) made their first contribution in [astral-sh/ruff#4169 - [@dependabot](https://togithub.com/dependabot) made their first contribution in [astral-sh/ruff#4354 **Full Changelog**: astral-sh/ruff@v0.0.265...v0.0.266 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.265` -> `==0.0.267` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/compatibility-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/confidence-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.267`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.267) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.266...v0.0.267)  #### Summary Follow-up release to v0.0.266 to fix an issue with `python -m ruff`- and `import ruff`-based workflows. (No new rules or functionality.) #### What's Changed ##### Rules - Implement `RUF010` to detect explicit type conversions within f-strings by [@LotemAm](https://togithub.com/LotemAm) in [astral-sh/ruff#4387 ##### Other Changes - Workaround for maturin bug by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4399 #### New Contributors - [@OMEGARAZER](https://togithub.com/OMEGARAZER) made their first contribution in [astral-sh/ruff#3938 - [@LotemAm](https://togithub.com/LotemAm) made their first contribution in [astral-sh/ruff#4387 **Full Changelog**: astral-sh/ruff@v0.0.266...v0.0.267 ### [`v0.0.266`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.266) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.265...v0.0.266)  #### What's Changed ##### Breaking Changes - Remove deprecated `update-check` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4313 - JSON Emitter: Use one indexed column numbers for edits by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4007 ##### Rules - \[`pygrep-hooks`] Implement pygrep-hook's Mock-mistake diagnostic by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4366 - \[`pylint`] Implement `nested-min-max` (`W3301`) by [@mccullocht](https://togithub.com/mccullocht) in [astral-sh/ruff#4200 - \[`flynt`] Implement Flynt static string join transform as FLY002 by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4196 - \[`pylint`] Include positional- and keyword-only arguments in too-many-arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4329 - \[`ruff`] Update confusable character mapping by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4274 ##### Settings - Add .git-rewrite folder to default ignored folder paths by [@jleclanche](https://togithub.com/jleclanche) in [astral-sh/ruff#4261 - Feat: detect changes also in configuration files by [@mikeleppane](https://togithub.com/mikeleppane) in [astral-sh/ruff#4169 ##### Bug Fixes - Revert the B027 autofix logic by [@aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4310 - Consider Flask app logger as logger candidate by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4253 - Enforce max-doc-length for multi-line docstrings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4347 - Avoid re-using imports beyond current edit site by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4378 - Respect insertion location when importing symbols by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4258 - Fix jemalloc page size on aarch64 by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4247 - Fix replace_whitespace() tabulation to space by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4226 - Avoid fixing `PD002` in a lambda expression by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4286 - Avoid `D403` if first char cannot be uppercased by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4283 - Avoid panics for f-string rewrites at start-of-file by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4291 - Rewrite `not not a` as `bool(a)` in boolean contexts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4294 - Include static and class methods in in abstract decorator list by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4298 - Specify exact command in incorrect parentheses suggestion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4300 - Ignore `TRY301` exceptions without except handlers by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4301 - Preserve whitespace around `ListComp` brackets in `C419` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4099 - Tweak capitalization of B021 message by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4350 - Avoid debug panic with empty indent replacement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4364 - Use target name in hardcoded-password diagnostics by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4365 - Avoid underflow in expected-special-method-signature by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4377 - Respect `__all__` imports when determining definition visibility by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4357 - Ignore some methods on list in `flake8-boolean-trap` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4385 - Fix false positives in PD002 by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4337 - Run autofix on initial watcher pass by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4311 - Avoid SIM105 autofixes that would remove comments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4330 - Handle `.encode` calls on parenthesized expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4338 - Truncate `SyntaxError`s before newline character by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4124 - Use non-empty ranges for logical-lines diagnostics by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4133 #### New Contributors - [@jleclanche](https://togithub.com/jleclanche) made their first contribution in [astral-sh/ruff#4261 - [@aureliojargas](https://togithub.com/aureliojargas) made their first contribution in [astral-sh/ruff#4306 - [@intgr](https://togithub.com/intgr) made their first contribution in [astral-sh/ruff#4304 - [@mikeleppane](https://togithub.com/mikeleppane) made their first contribution in [astral-sh/ruff#4169 - [@dependabot](https://togithub.com/dependabot) made their first contribution in [astral-sh/ruff#4354 **Full Changelog**: astral-sh/ruff@v0.0.265...v0.0.266 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.265` -> `==0.0.267` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/compatibility-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/confidence-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.267`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.267) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.266...v0.0.267)  #### Summary Follow-up release to v0.0.266 to fix an issue with `python -m ruff`- and `import ruff`-based workflows. (No new rules or functionality.) #### What's Changed ##### Rules - Implement `RUF010` to detect explicit type conversions within f-strings by [@LotemAm](https://togithub.com/LotemAm) in [astral-sh/ruff#4387 ##### Other Changes - Workaround for maturin bug by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4399 #### New Contributors - [@OMEGARAZER](https://togithub.com/OMEGARAZER) made their first contribution in [astral-sh/ruff#3938 - [@LotemAm](https://togithub.com/LotemAm) made their first contribution in [astral-sh/ruff#4387 **Full Changelog**: astral-sh/ruff@v0.0.266...v0.0.267 ### [`v0.0.266`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.266) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.265...v0.0.266)  #### What's Changed ##### Breaking Changes - Remove deprecated `update-check` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4313 - JSON Emitter: Use one indexed column numbers for edits by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4007 ##### Rules - \[`pygrep-hooks`] Implement pygrep-hook's Mock-mistake diagnostic by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4366 - \[`pylint`] Implement `nested-min-max` (`W3301`) by [@mccullocht](https://togithub.com/mccullocht) in [astral-sh/ruff#4200 - \[`flynt`] Implement Flynt static string join transform as FLY002 by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4196 - \[`pylint`] Include positional- and keyword-only arguments in too-many-arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4329 - \[`ruff`] Update confusable character mapping by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4274 ##### Settings - Add .git-rewrite folder to default ignored folder paths by [@jleclanche](https://togithub.com/jleclanche) in [astral-sh/ruff#4261 - Feat: detect changes also in configuration files by [@mikeleppane](https://togithub.com/mikeleppane) in [astral-sh/ruff#4169 ##### Bug Fixes - Revert the B027 autofix logic by [@aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4310 - Consider Flask app logger as logger candidate by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4253 - Enforce max-doc-length for multi-line docstrings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4347 - Avoid re-using imports beyond current edit site by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4378 - Respect insertion location when importing symbols by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4258 - Fix jemalloc page size on aarch64 by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4247 - Fix replace_whitespace() tabulation to space by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4226 - Avoid fixing `PD002` in a lambda expression by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4286 - Avoid `D403` if first char cannot be uppercased by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4283 - Avoid panics for f-string rewrites at start-of-file by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4291 - Rewrite `not not a` as `bool(a)` in boolean contexts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4294 - Include static and class methods in in abstract decorator list by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4298 - Specify exact command in incorrect parentheses suggestion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4300 - Ignore `TRY301` exceptions without except handlers by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4301 - Preserve whitespace around `ListComp` brackets in `C419` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4099 - Tweak capitalization of B021 message by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4350 - Avoid debug panic with empty indent replacement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4364 - Use target name in hardcoded-password diagnostics by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4365 - Avoid underflow in expected-special-method-signature by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4377 - Respect `__all__` imports when determining definition visibility by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4357 - Ignore some methods on list in `flake8-boolean-trap` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4385 - Fix false positives in PD002 by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4337 - Run autofix on initial watcher pass by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4311 - Avoid SIM105 autofixes that would remove comments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4330 - Handle `.encode` calls on parenthesized expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4338 - Truncate `SyntaxError`s before newline character by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4124 - Use non-empty ranges for logical-lines diagnostics by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4133 #### New Contributors - [@jleclanche](https://togithub.com/jleclanche) made their first contribution in [astral-sh/ruff#4261 - [@aureliojargas](https://togithub.com/aureliojargas) made their first contribution in [astral-sh/ruff#4306 - [@intgr](https://togithub.com/intgr) made their first contribution in [astral-sh/ruff#4304 - [@mikeleppane](https://togithub.com/mikeleppane) made their first contribution in [astral-sh/ruff#4169 - [@dependabot](https://togithub.com/dependabot) made their first contribution in [astral-sh/ruff#4354 **Full Changelog**: astral-sh/ruff@v0.0.265...v0.0.266 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Avoid fixing PD002 in a lambda expression

c7053fb

charliermarsh reviewed May 8, 2023

View reviewed changes

Add TODO

f829d71

charliermarsh enabled auto-merge (squash) May 8, 2023 18:19

charliermarsh merged commit 3344d36 into astral-sh:main May 8, 2023
12 checks passed

dhruvmanila deleted the fix/PD002/no-assign-in-lambda branch May 8, 2023 23:15

charliermarsh mentioned this pull request May 10, 2023

[Autofix error] Autofix error when extending array #3621

Closed

p-linnane mentioned this pull request May 12, 2023

ruff 0.0.267 Homebrew/homebrew-core#130865

Merged

renovate bot mentioned this pull request Jun 21, 2023

⬆️ deps: Update dependencies (non-major) cattidea/doc-pipe#22

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid fixing `PD002` in a lambda expression #4286

Avoid fixing `PD002` in a lambda expression #4286

dhruvmanila commented May 8, 2023

github-actions bot commented May 8, 2023 •

edited

charliermarsh May 8, 2023

charliermarsh May 8, 2023

dhruvmanila May 8, 2023

Avoid fixing PD002 in a lambda expression #4286

Avoid fixing PD002 in a lambda expression #4286

Conversation

dhruvmanila commented May 8, 2023

github-actions bot commented May 8, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh May 8, 2023

Choose a reason for hiding this comment

charliermarsh May 8, 2023

Choose a reason for hiding this comment

dhruvmanila May 8, 2023

Choose a reason for hiding this comment

Avoid fixing `PD002` in a lambda expression #4286

Avoid fixing `PD002` in a lambda expression #4286

github-actions bot commented May 8, 2023 •

edited