Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pygrep-hook's Mock-mistake diagnostic #4366

Merged
merged 1 commit into from May 11, 2023
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 11, 2023

Adds a new rule, PGH005, to close out pygrep-hooks.

This rule checks for common mistakes when interacting with mocks, e.g., using assert my_mock.called_once_with() instead of my_mock.assert_called_once_with().

Closes #980.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label May 11, 2023
@charliermarsh
Copy link
Member Author

Random PR but I just want to close out the issue and remove the TODOs from the README etc.

@charliermarsh charliermarsh enabled auto-merge (squash) May 11, 2023 03:24
@charliermarsh charliermarsh merged commit 865205d into main May 11, 2023
12 checks passed
@charliermarsh charliermarsh deleted the charlie/pygrep branch May 11, 2023 03:26
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+26, -0, 0 error(s))

airflow (+24, -0)

+ tests/executors/test_celery_executor.py:248:16: PGH005 Non-existent mock method: `called_with`
+ tests/executors/test_celery_executor.py:249:16: PGH005 Non-existent mock method: `called_once`
+ tests/kubernetes/test_client.py:34:16: PGH005 Non-existent mock method: `not_called`
+ tests/kubernetes/test_client.py:39:16: PGH005 Non-existent mock method: `not_called`
+ tests/providers/amazon/aws/operators/test_eks.py:466:9: PGH005 Mock method should be called: `assert_called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:113:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:114:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:137:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:139:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:57:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:58:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:73:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:74:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:93:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/apache/druid/hooks/test_druid.py:94:16: PGH005 Non-existent mock method: `called_once`
+ tests/providers/microsoft/azure/hooks/test_adx.py:107:16: PGH005 Non-existent mock method: `called_with`
+ tests/providers/microsoft/azure/hooks/test_adx.py:132:16: PGH005 Non-existent mock method: `called_with`
+ tests/providers/microsoft/azure/hooks/test_adx.py:158:16: PGH005 Non-existent mock method: `called_with`
+ tests/providers/microsoft/azure/hooks/test_adx.py:176:16: PGH005 Non-existent mock method: `called_with`
+ tests/providers/microsoft/azure/hooks/test_adx.py:195:16: PGH005 Non-existent mock method: `called_with`
+ tests/www/test_security.py:914:12: PGH005 Non-existent mock method: `called_once`
+ tests/www/test_security.py:924:12: PGH005 Non-existent mock method: `called_once`
+ tests/www/test_security.py:934:12: PGH005 Non-existent mock method: `called_once`
+ tests/www/test_security.py:944:12: PGH005 Non-existent mock method: `called_once`

bokeh (+2, -0)

+ tests/unit/bokeh/core/property/test_descriptors.py:86:16: PGH005 Non-existent mock method: `called_once_with`
+ tests/unit/bokeh/core/property/test_descriptors.py:87:16: PGH005 Non-existent mock method: `called_once_with`

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     13.6±0.02ms     3.0 MB/sec    1.02     13.8±0.10ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.01ms     5.0 MB/sec    1.00      3.3±0.00ms     5.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    416.1±3.65µs     7.1 MB/sec    1.00    415.8±0.69µs     7.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.7±0.03ms     4.5 MB/sec    1.01      5.8±0.05ms     4.4 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.02ms     6.0 MB/sec    1.01      6.8±0.02ms     5.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1453.4±2.73µs    11.5 MB/sec    1.01   1470.2±2.26µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    160.1±0.68µs    18.4 MB/sec    1.02    163.2±2.89µs    18.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.4 MB/sec    1.02      3.1±0.01ms     8.2 MB/sec
parser/large/dataset.py                    1.00      5.3±0.00ms     7.6 MB/sec    1.02      5.4±0.00ms     7.5 MB/sec
parser/numpy/ctypeslib.py                  1.00   1037.3±1.34µs    16.1 MB/sec    1.02   1055.6±1.26µs    15.8 MB/sec
parser/numpy/globals.py                    1.00    105.9±0.36µs    27.9 MB/sec    1.02    107.6±0.23µs    27.4 MB/sec
parser/pydantic/types.py                   1.00      2.3±0.00ms    11.2 MB/sec    1.02      2.3±0.00ms    11.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     18.4±0.63ms     2.2 MB/sec    1.04     19.1±0.62ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.6±0.16ms     3.6 MB/sec    1.03      4.8±0.18ms     3.5 MB/sec
linter/all-rules/numpy/globals.py          1.00   571.1±31.89µs     5.2 MB/sec    1.00   573.5±27.88µs     5.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.9±0.26ms     3.2 MB/sec    1.07      8.4±0.28ms     3.0 MB/sec
linter/default-rules/large/dataset.py      1.00      9.4±0.32ms     4.3 MB/sec    1.02      9.6±0.39ms     4.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01      2.0±0.08ms     8.3 MB/sec    1.00  1983.4±93.51µs     8.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    226.0±9.80µs    13.1 MB/sec    1.01   229.2±14.43µs    12.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.2±0.21ms     6.0 MB/sec    1.02      4.3±0.21ms     5.9 MB/sec
parser/large/dataset.py                    1.05      8.1±0.19ms     5.0 MB/sec    1.00      7.8±0.21ms     5.2 MB/sec
parser/numpy/ctypeslib.py                  1.06  1537.4±65.61µs    10.8 MB/sec    1.00  1452.8±63.69µs    11.5 MB/sec
parser/numpy/globals.py                    1.00    144.0±9.02µs    20.5 MB/sec    1.04    150.1±8.25µs    19.7 MB/sec
parser/pydantic/types.py                   1.00      3.3±0.30ms     7.7 MB/sec    1.00      3.3±0.11ms     7.7 MB/sec

renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request May 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff)
([changelog](https://togithub.com/charliermarsh/ruff/releases)) |
`^0.0.265` -> `^0.0.267` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/compatibility-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/confidence-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.267`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.267)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.266...v0.0.267)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### Summary

Follow-up release to v0.0.266 to fix an issue with `python -m ruff`- and
`import ruff`-based workflows.

(No new rules or functionality.)

#### What's Changed

##### Rules

- Implement `RUF010` to detect explicit type conversions within
f-strings by [@&#8203;LotemAm](https://togithub.com/LotemAm) in
[astral-sh/ruff#4387

##### Other Changes

- Workaround for maturin bug by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#4399

#### New Contributors

- [@&#8203;OMEGARAZER](https://togithub.com/OMEGARAZER) made their first
contribution in
[astral-sh/ruff#3938
- [@&#8203;LotemAm](https://togithub.com/LotemAm) made their first
contribution in
[astral-sh/ruff#4387

**Full Changelog**:
astral-sh/ruff@v0.0.266...v0.0.267

###
[`v0.0.266`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.266)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.265...v0.0.266)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Breaking Changes

- Remove deprecated `update-check` setting by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4313
- JSON Emitter: Use one indexed column numbers for edits by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4007

##### Rules

- \[`pygrep-hooks`] Implement pygrep-hook's Mock-mistake diagnostic by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4366
- \[`pylint`] Implement `nested-min-max` (`W3301`) by
[@&#8203;mccullocht](https://togithub.com/mccullocht) in
[astral-sh/ruff#4200
- \[`flynt`] Implement Flynt static string join transform as FLY002 by
[@&#8203;akx](https://togithub.com/akx) in
[astral-sh/ruff#4196
- \[`pylint`] Include positional- and keyword-only arguments in
too-many-arguments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4329
- \[`ruff`] Update confusable character mapping by
[@&#8203;akx](https://togithub.com/akx) in
[astral-sh/ruff#4274

##### Settings

- Add .git-rewrite folder to default ignored folder paths by
[@&#8203;jleclanche](https://togithub.com/jleclanche) in
[astral-sh/ruff#4261
- Feat: detect changes also in configuration files by
[@&#8203;mikeleppane](https://togithub.com/mikeleppane) in
[astral-sh/ruff#4169

##### Bug Fixes

- Revert the B027 autofix logic by
[@&#8203;aacunningham](https://togithub.com/aacunningham) in
[astral-sh/ruff#4310
- Consider Flask app logger as logger candidate by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4253
- Enforce max-doc-length for multi-line docstrings by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4347
- Avoid re-using imports beyond current edit site by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4378
- Respect insertion location when importing symbols by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4258
- Fix jemalloc page size on aarch64 by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4247
- Fix replace_whitespace() tabulation to space by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#4226
- Avoid fixing `PD002` in a lambda expression by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4286
- Avoid `D403` if first char cannot be uppercased by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4283
- Avoid panics for f-string rewrites at start-of-file by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4291
- Rewrite `not not a` as `bool(a)` in boolean contexts by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4294
- Include static and class methods in in abstract decorator list by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4298
- Specify exact command in incorrect parentheses suggestion by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4300
- Ignore `TRY301` exceptions without except handlers by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4301
- Preserve whitespace around `ListComp` brackets in `C419` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4099
- Tweak capitalization of B021 message by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4350
- Avoid debug panic with empty indent replacement by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4364
- Use target name in hardcoded-password diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4365
- Avoid underflow in expected-special-method-signature by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4377
- Respect `__all__` imports when determining definition visibility by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4357
- Ignore some methods on list in `flake8-boolean-trap` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4385
- Fix false positives in PD002 by
[@&#8203;evanrittenhouse](https://togithub.com/evanrittenhouse) in
[astral-sh/ruff#4337
- Run autofix on initial watcher pass by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4311
- Avoid SIM105 autofixes that would remove comments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4330
- Handle `.encode` calls on parenthesized expressions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4338
- Truncate `SyntaxError`s before newline character by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4124
- Use non-empty ranges for logical-lines diagnostics by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4133

#### New Contributors

- [@&#8203;jleclanche](https://togithub.com/jleclanche) made their first
contribution in
[astral-sh/ruff#4261
- [@&#8203;aureliojargas](https://togithub.com/aureliojargas) made their
first contribution in
[astral-sh/ruff#4306
- [@&#8203;intgr](https://togithub.com/intgr) made their first
contribution in
[astral-sh/ruff#4304
- [@&#8203;mikeleppane](https://togithub.com/mikeleppane) made their
first contribution in
[astral-sh/ruff#4169
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[astral-sh/ruff#4354

**Full Changelog**:
astral-sh/ruff@v0.0.265...v0.0.266

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to allenporter/flux-local that referenced this pull request May 14, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff)
([changelog](https://togithub.com/charliermarsh/ruff/releases)) |
`==0.0.265` -> `==0.0.267` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/compatibility-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/confidence-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.267`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.267)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.266...v0.0.267)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### Summary

Follow-up release to v0.0.266 to fix an issue with `python -m ruff`- and
`import ruff`-based workflows.

(No new rules or functionality.)

#### What's Changed

##### Rules

- Implement `RUF010` to detect explicit type conversions within
f-strings by [@&#8203;LotemAm](https://togithub.com/LotemAm) in
[astral-sh/ruff#4387

##### Other Changes

- Workaround for maturin bug by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#4399

#### New Contributors

- [@&#8203;OMEGARAZER](https://togithub.com/OMEGARAZER) made their first
contribution in
[astral-sh/ruff#3938
- [@&#8203;LotemAm](https://togithub.com/LotemAm) made their first
contribution in
[astral-sh/ruff#4387

**Full Changelog**:
astral-sh/ruff@v0.0.266...v0.0.267

###
[`v0.0.266`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.266)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.265...v0.0.266)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Breaking Changes

- Remove deprecated `update-check` setting by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4313
- JSON Emitter: Use one indexed column numbers for edits by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4007

##### Rules

- \[`pygrep-hooks`] Implement pygrep-hook's Mock-mistake diagnostic by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4366
- \[`pylint`] Implement `nested-min-max` (`W3301`) by
[@&#8203;mccullocht](https://togithub.com/mccullocht) in
[astral-sh/ruff#4200
- \[`flynt`] Implement Flynt static string join transform as FLY002 by
[@&#8203;akx](https://togithub.com/akx) in
[astral-sh/ruff#4196
- \[`pylint`] Include positional- and keyword-only arguments in
too-many-arguments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4329
- \[`ruff`] Update confusable character mapping by
[@&#8203;akx](https://togithub.com/akx) in
[astral-sh/ruff#4274

##### Settings

- Add .git-rewrite folder to default ignored folder paths by
[@&#8203;jleclanche](https://togithub.com/jleclanche) in
[astral-sh/ruff#4261
- Feat: detect changes also in configuration files by
[@&#8203;mikeleppane](https://togithub.com/mikeleppane) in
[astral-sh/ruff#4169

##### Bug Fixes

- Revert the B027 autofix logic by
[@&#8203;aacunningham](https://togithub.com/aacunningham) in
[astral-sh/ruff#4310
- Consider Flask app logger as logger candidate by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4253
- Enforce max-doc-length for multi-line docstrings by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4347
- Avoid re-using imports beyond current edit site by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4378
- Respect insertion location when importing symbols by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4258
- Fix jemalloc page size on aarch64 by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4247
- Fix replace_whitespace() tabulation to space by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#4226
- Avoid fixing `PD002` in a lambda expression by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4286
- Avoid `D403` if first char cannot be uppercased by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4283
- Avoid panics for f-string rewrites at start-of-file by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4291
- Rewrite `not not a` as `bool(a)` in boolean contexts by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4294
- Include static and class methods in in abstract decorator list by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4298
- Specify exact command in incorrect parentheses suggestion by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4300
- Ignore `TRY301` exceptions without except handlers by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4301
- Preserve whitespace around `ListComp` brackets in `C419` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4099
- Tweak capitalization of B021 message by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4350
- Avoid debug panic with empty indent replacement by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4364
- Use target name in hardcoded-password diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4365
- Avoid underflow in expected-special-method-signature by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4377
- Respect `__all__` imports when determining definition visibility by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4357
- Ignore some methods on list in `flake8-boolean-trap` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4385
- Fix false positives in PD002 by
[@&#8203;evanrittenhouse](https://togithub.com/evanrittenhouse) in
[astral-sh/ruff#4337
- Run autofix on initial watcher pass by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4311
- Avoid SIM105 autofixes that would remove comments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4330
- Handle `.encode` calls on parenthesized expressions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4338
- Truncate `SyntaxError`s before newline character by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4124
- Use non-empty ranges for logical-lines diagnostics by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4133

#### New Contributors

- [@&#8203;jleclanche](https://togithub.com/jleclanche) made their first
contribution in
[astral-sh/ruff#4261
- [@&#8203;aureliojargas](https://togithub.com/aureliojargas) made their
first contribution in
[astral-sh/ruff#4306
- [@&#8203;intgr](https://togithub.com/intgr) made their first
contribution in
[astral-sh/ruff#4304
- [@&#8203;mikeleppane](https://togithub.com/mikeleppane) made their
first contribution in
[astral-sh/ruff#4169
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[astral-sh/ruff#4354

**Full Changelog**:
astral-sh/ruff@v0.0.265...v0.0.266

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to allenporter/pyrainbird that referenced this pull request May 14, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff)
([changelog](https://togithub.com/charliermarsh/ruff/releases)) |
`==0.0.265` -> `==0.0.267` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/compatibility-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.267/confidence-slim/0.0.265)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.267`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.267)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.266...v0.0.267)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### Summary

Follow-up release to v0.0.266 to fix an issue with `python -m ruff`- and
`import ruff`-based workflows.

(No new rules or functionality.)

#### What's Changed

##### Rules

- Implement `RUF010` to detect explicit type conversions within
f-strings by [@&#8203;LotemAm](https://togithub.com/LotemAm) in
[astral-sh/ruff#4387

##### Other Changes

- Workaround for maturin bug by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#4399

#### New Contributors

- [@&#8203;OMEGARAZER](https://togithub.com/OMEGARAZER) made their first
contribution in
[astral-sh/ruff#3938
- [@&#8203;LotemAm](https://togithub.com/LotemAm) made their first
contribution in
[astral-sh/ruff#4387

**Full Changelog**:
astral-sh/ruff@v0.0.266...v0.0.267

###
[`v0.0.266`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.266)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.265...v0.0.266)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Breaking Changes

- Remove deprecated `update-check` setting by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4313
- JSON Emitter: Use one indexed column numbers for edits by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4007

##### Rules

- \[`pygrep-hooks`] Implement pygrep-hook's Mock-mistake diagnostic by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4366
- \[`pylint`] Implement `nested-min-max` (`W3301`) by
[@&#8203;mccullocht](https://togithub.com/mccullocht) in
[astral-sh/ruff#4200
- \[`flynt`] Implement Flynt static string join transform as FLY002 by
[@&#8203;akx](https://togithub.com/akx) in
[astral-sh/ruff#4196
- \[`pylint`] Include positional- and keyword-only arguments in
too-many-arguments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4329
- \[`ruff`] Update confusable character mapping by
[@&#8203;akx](https://togithub.com/akx) in
[astral-sh/ruff#4274

##### Settings

- Add .git-rewrite folder to default ignored folder paths by
[@&#8203;jleclanche](https://togithub.com/jleclanche) in
[astral-sh/ruff#4261
- Feat: detect changes also in configuration files by
[@&#8203;mikeleppane](https://togithub.com/mikeleppane) in
[astral-sh/ruff#4169

##### Bug Fixes

- Revert the B027 autofix logic by
[@&#8203;aacunningham](https://togithub.com/aacunningham) in
[astral-sh/ruff#4310
- Consider Flask app logger as logger candidate by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4253
- Enforce max-doc-length for multi-line docstrings by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4347
- Avoid re-using imports beyond current edit site by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4378
- Respect insertion location when importing symbols by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4258
- Fix jemalloc page size on aarch64 by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4247
- Fix replace_whitespace() tabulation to space by
[@&#8203;JonathanPlasse](https://togithub.com/JonathanPlasse) in
[astral-sh/ruff#4226
- Avoid fixing `PD002` in a lambda expression by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4286
- Avoid `D403` if first char cannot be uppercased by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4283
- Avoid panics for f-string rewrites at start-of-file by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4291
- Rewrite `not not a` as `bool(a)` in boolean contexts by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4294
- Include static and class methods in in abstract decorator list by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4298
- Specify exact command in incorrect parentheses suggestion by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4300
- Ignore `TRY301` exceptions without except handlers by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4301
- Preserve whitespace around `ListComp` brackets in `C419` by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#4099
- Tweak capitalization of B021 message by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4350
- Avoid debug panic with empty indent replacement by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4364
- Use target name in hardcoded-password diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4365
- Avoid underflow in expected-special-method-signature by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4377
- Respect `__all__` imports when determining definition visibility by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4357
- Ignore some methods on list in `flake8-boolean-trap` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4385
- Fix false positives in PD002 by
[@&#8203;evanrittenhouse](https://togithub.com/evanrittenhouse) in
[astral-sh/ruff#4337
- Run autofix on initial watcher pass by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4311
- Avoid SIM105 autofixes that would remove comments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4330
- Handle `.encode` calls on parenthesized expressions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#4338
- Truncate `SyntaxError`s before newline character by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4124
- Use non-empty ranges for logical-lines diagnostics by
[@&#8203;MichaReiser](https://togithub.com/MichaReiser) in
[astral-sh/ruff#4133

#### New Contributors

- [@&#8203;jleclanche](https://togithub.com/jleclanche) made their first
contribution in
[astral-sh/ruff#4261
- [@&#8203;aureliojargas](https://togithub.com/aureliojargas) made their
first contribution in
[astral-sh/ruff#4306
- [@&#8203;intgr](https://togithub.com/intgr) made their first
contribution in
[astral-sh/ruff#4304
- [@&#8203;mikeleppane](https://togithub.com/mikeleppane) made their
first contribution in
[astral-sh/ruff#4169
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[astral-sh/ruff#4354

**Full Changelog**:
astral-sh/ruff@v0.0.265...v0.0.266

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pygrep-hooks
1 participant