Fix RUF010 auto-fix with parenthesis #4524

JonathanPlasse · 2023-05-19T09:30:25Z

Close [Autofix error] RUF010 autofix fails when the expression is in parentheses, e.g. f"{(str(a))}" #4520
From Fix RUF010 autofix within f-strings #4423

It looks like we now generate one diagnostic for the whole f-string (and that the diagnostic range is that of the entire f-string).

I think it'd be preferable to retain one diagnostic per formatted value, and limit the diagnostic to the formatted value. It's fine if the autofix contents include the whole string, even for each formatted value, but they should be separate diagnostics. (E.g., we could iterate over formatted_values and create one diagnostic per index, with a fix specific to that index.)

github-actions · 2023-05-19T09:39:10Z

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+7, -26, 0 error(s))

airflow (+1, -12)

- airflow/exceptions.py:299:49: RUF010 [*] Use conversion in f-string
- airflow/policies.py:170:43: RUF010 [*] Use conversion in f-string
- airflow/providers/amazon/aws/log/cloudwatch_task_handler.py:99:40: RUF010 [*] Use conversion in f-string
- airflow/providers/apache/livy/triggers/livy.py:104:80: RUF010 [*] Use conversion in f-string
- airflow/providers/apache/spark/hooks/spark_submit.py:270:51: RUF010 [*] Use conversion in f-string
+ airflow/providers/grpc/hooks/grpc.py:115:33: RUF010 Use conversion in f-string
- airflow/providers/grpc/hooks/grpc.py:115:33: RUF010 [*] Use conversion in f-string
- airflow/providers/sftp/operators/sftp.py:188:83: RUF010 [*] Use conversion in f-string
- airflow/task/task_runner/cgroup_task_runner.py:137:84: RUF010 [*] Use conversion in f-string
- tests/integration/executors/test_celery_executor.py:247:56: RUF010 [*] Use conversion in f-string
- tests/models/test_baseoperator.py:53:56: RUF010 [*] Use conversion in f-string
- tests/models/test_renderedtifields.py:51:56: RUF010 [*] Use conversion in f-string
- tests/serialization/test_dag_serialization.py:1053:49: RUF010 [*] Use conversion in f-string

zulip (+6, -14)

- zerver/lib/data_types.py:107:33: RUF010 [*] Use conversion in f-string
- zerver/lib/queue.py:97:32: RUF010 [*] Use conversion in f-string
- zerver/lib/test_classes.py:1068:62: RUF010 [*] Use conversion in f-string
- zerver/lib/test_classes.py:1192:45: RUF010 [*] Use conversion in f-string
- zerver/tests/test_openapi.py:385:31: RUF010 [*] Use conversion in f-string
- zerver/tests/test_openapi.py:385:50: RUF010 [*] Use conversion in f-string
+ zerver/tests/test_push_notifications.py:1031:115: RUF010 Use conversion in f-string
- zerver/tests/test_push_notifications.py:1031:115: RUF010 [*] Use conversion in f-string
+ zerver/tests/test_push_notifications.py:1031:149: RUF010 Use conversion in f-string
- zerver/tests/test_push_notifications.py:1031:149: RUF010 [*] Use conversion in f-string
+ zerver/tests/test_push_notifications.py:1038:59: RUF010 Use conversion in f-string
- zerver/tests/test_push_notifications.py:1038:59: RUF010 [*] Use conversion in f-string
+ zerver/tests/test_push_notifications.py:1038:93: RUF010 Use conversion in f-string
- zerver/tests/test_push_notifications.py:1038:93: RUF010 [*] Use conversion in f-string
+ zerver/tests/test_push_notifications.py:1092:115: RUF010 Use conversion in f-string
- zerver/tests/test_push_notifications.py:1092:115: RUF010 [*] Use conversion in f-string
+ zerver/tests/test_push_notifications.py:1092:149: RUF010 Use conversion in f-string
- zerver/tests/test_push_notifications.py:1092:149: RUF010 [*] Use conversion in f-string
- zerver/tests/test_push_notifications.py:401:104: RUF010 [*] Use conversion in f-string
- zerver/tests/test_push_notifications.py:403:129: RUF010 [*] Use conversion in f-string

Rules changed: 1

Rule	Changes	Additions	Removals
RUF010	33	7	26

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.2±0.11ms     2.9 MB/sec    1.01     14.4±0.13ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.01ms     4.8 MB/sec    1.00      3.4±0.01ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    424.4±0.94µs     7.0 MB/sec    1.00    423.4±0.92µs     7.0 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.9±0.02ms     4.4 MB/sec    1.01      5.9±0.03ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.01ms     6.0 MB/sec    1.01      6.8±0.02ms     6.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1459.0±4.25µs    11.4 MB/sec    1.01   1469.9±3.44µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    161.2±0.30µs    18.3 MB/sec    1.02    165.1±0.40µs    17.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.4 MB/sec    1.01      3.1±0.00ms     8.3 MB/sec
parser/large/dataset.py                    1.00      5.4±0.00ms     7.6 MB/sec    1.16      6.3±0.01ms     6.5 MB/sec
parser/numpy/ctypeslib.py                  1.00   1059.4±0.56µs    15.7 MB/sec    1.13   1196.6±0.54µs    13.9 MB/sec
parser/numpy/globals.py                    1.00    109.1±0.61µs    27.0 MB/sec    1.10    120.1±0.25µs    24.6 MB/sec
parser/pydantic/types.py                   1.00      2.3±0.00ms    11.1 MB/sec    1.14      2.6±0.00ms     9.8 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     18.5±0.94ms     2.2 MB/sec    1.00     18.5±0.91ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.09      5.2±0.45ms     3.2 MB/sec    1.00      4.8±0.29ms     3.5 MB/sec
linter/all-rules/numpy/globals.py          1.00   547.4±32.92µs     5.4 MB/sec    1.10   602.8±57.15µs     4.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.8±0.38ms     3.3 MB/sec    1.02      7.9±0.51ms     3.2 MB/sec
linter/default-rules/large/dataset.py      1.01      9.4±0.55ms     4.3 MB/sec    1.00      9.3±0.48ms     4.4 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1933.6±85.28µs     8.6 MB/sec    1.04      2.0±0.12ms     8.3 MB/sec
linter/default-rules/numpy/globals.py      1.00   230.4±10.42µs    12.8 MB/sec    1.10   254.0±26.00µs    11.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.1±0.26ms     6.2 MB/sec    1.04      4.3±0.30ms     5.9 MB/sec
parser/large/dataset.py                    1.02      8.0±0.51ms     5.1 MB/sec    1.00      7.9±0.35ms     5.2 MB/sec
parser/numpy/ctypeslib.py                  1.00  1475.4±78.79µs    11.3 MB/sec    1.04  1529.5±92.09µs    10.9 MB/sec
parser/numpy/globals.py                    1.00   155.1±10.49µs    19.0 MB/sec    1.05   162.4±11.74µs    18.2 MB/sec
parser/pydantic/types.py                   1.03      3.5±0.23ms     7.4 MB/sec    1.00      3.4±0.21ms     7.6 MB/sec

crates/ruff/src/cst/matchers.rs

crates/ruff/src/rules/ruff/rules/explicit_f_string_type_conversion.rs

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.269` -> `^0.0.270` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/compatibility-slim/0.0.269)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/confidence-slim/0.0.269)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.270`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.270) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.269...v0.0.270)  #### What's Changed ##### Rules - \[`flake8-bandit`] Implement `paramiko-call` (`S601`) by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4500 - \[`flake8-pyi`] Add autofix for PYI009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4583 - \[`flake8-pyi`] Implement `PYI013` by [@density](https://togithub.com/density) in [astral-sh/ruff#4517 - \[`pylint`] Add `duplicate-value` (`W0130`) by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4515 - \[`pylint`] Add `named_expr_without_context` (`W0131`) by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4531 - \[`ruff`] Extend `RUF005` to recursive and literal-literal concatenations by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4557 - \[`ruff`] Make ambiguous-unicode detection sensitive to 'word' context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4552 - \[`ruff`] Name ambiguous characters by [@covracer](https://togithub.com/covracer) in [astral-sh/ruff#4448 ##### Settings - Implement `--extend-fixable` option by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4297 - Support new `extend-per-file-ignores` setting by [@aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4265 ##### Bug Fixes - Fix RUF010 auto-fix with parenthesis by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4524 - Parenthesize more sub-expressions in f-string conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4535 - Fix false-positive for TRY302 if exception cause is given by [@153957](https://togithub.com/153957) in [astral-sh/ruff#4559 - Fix `# isort: split` comment detection in nested blocks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4584 - Avoid some false positives in dunder variable assigments by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4508 - Fix UP032 auto-fix with integers by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4525 - Improve reference resolution for deferred-annotations-within-classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4509 - Improve handling of `__qualname__`, `__module__`, and `__class__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4512 - Include empty success test in JUnit output by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4537 - Fix SIM110 and SIM111 ranges by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4545 - Ignore `#region` code folding marks in eradicate rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4546 - Avoid infinite loop for required imports with isort: off by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4581 - Make B007 fix relevance stricter by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4607 - Introduce `tab-size` to correcly calculate the line length with tabulations by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4167 - Visit `TypeVar` and `NewType` name arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4627 - Improve `Message` sorting performance by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4624 #### New Contributors - [@hoel-bagard](https://togithub.com/hoel-bagard) made their first contribution in [astral-sh/ruff#4516 - [@density](https://togithub.com/density) made their first contribution in [astral-sh/ruff#4517 - [@Mr-Pepe](https://togithub.com/Mr-Pepe) made their first contribution in [astral-sh/ruff#4540 - [@153957](https://togithub.com/153957) made their first contribution in [astral-sh/ruff#4559 - [@covracer](https://togithub.com/covracer) made their first contribution in [astral-sh/ruff#4448 **Full Changelog**: astral-sh/ruff@v0.0.269...v0.0.270 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.269` -> `==0.0.270` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/compatibility-slim/0.0.269)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/confidence-slim/0.0.269)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.270`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.270) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.269...v0.0.270)  #### What's Changed ##### Rules - \[`flake8-bandit`] Implement `paramiko-call` (`S601`) by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4500 - \[`flake8-pyi`] Add autofix for PYI009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4583 - \[`flake8-pyi`] Implement `PYI013` by [@density](https://togithub.com/density) in [astral-sh/ruff#4517 - \[`pylint`] Add `duplicate-value` (`W0130`) by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4515 - \[`pylint`] Add `named_expr_without_context` (`W0131`) by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4531 - \[`ruff`] Extend `RUF005` to recursive and literal-literal concatenations by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4557 - \[`ruff`] Make ambiguous-unicode detection sensitive to 'word' context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4552 - \[`ruff`] Name ambiguous characters by [@covracer](https://togithub.com/covracer) in [astral-sh/ruff#4448 ##### Settings - Implement `--extend-fixable` option by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4297 - Support new `extend-per-file-ignores` setting by [@aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4265 ##### Bug Fixes - Fix RUF010 auto-fix with parenthesis by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4524 - Parenthesize more sub-expressions in f-string conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4535 - Fix false-positive for TRY302 if exception cause is given by [@153957](https://togithub.com/153957) in [astral-sh/ruff#4559 - Fix `# isort: split` comment detection in nested blocks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4584 - Avoid some false positives in dunder variable assigments by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4508 - Fix UP032 auto-fix with integers by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4525 - Improve reference resolution for deferred-annotations-within-classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4509 - Improve handling of `__qualname__`, `__module__`, and `__class__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4512 - Include empty success test in JUnit output by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4537 - Fix SIM110 and SIM111 ranges by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4545 - Ignore `#region` code folding marks in eradicate rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4546 - Avoid infinite loop for required imports with isort: off by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4581 - Make B007 fix relevance stricter by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4607 - Introduce `tab-size` to correcly calculate the line length with tabulations by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4167 - Visit `TypeVar` and `NewType` name arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4627 - Improve `Message` sorting performance by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4624 #### New Contributors - [@hoel-bagard](https://togithub.com/hoel-bagard) made their first contribution in [astral-sh/ruff#4516 - [@density](https://togithub.com/density) made their first contribution in [astral-sh/ruff#4517 - [@Mr-Pepe](https://togithub.com/Mr-Pepe) made their first contribution in [astral-sh/ruff#4540 - [@153957](https://togithub.com/153957) made their first contribution in [astral-sh/ruff#4559 - [@covracer](https://togithub.com/covracer) made their first contribution in [astral-sh/ruff#4448 **Full Changelog**: astral-sh/ruff@v0.0.269...v0.0.270 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.269` -> `==0.0.270` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/compatibility-slim/0.0.269)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.270/confidence-slim/0.0.269)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.270`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.270) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.269...v0.0.270)  #### What's Changed ##### Rules - \[`flake8-bandit`] Implement `paramiko-call` (`S601`) by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4500 - \[`flake8-pyi`] Add autofix for PYI009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4583 - \[`flake8-pyi`] Implement `PYI013` by [@density](https://togithub.com/density) in [astral-sh/ruff#4517 - \[`pylint`] Add `duplicate-value` (`W0130`) by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4515 - \[`pylint`] Add `named_expr_without_context` (`W0131`) by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4531 - \[`ruff`] Extend `RUF005` to recursive and literal-literal concatenations by [@hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4557 - \[`ruff`] Make ambiguous-unicode detection sensitive to 'word' context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4552 - \[`ruff`] Name ambiguous characters by [@covracer](https://togithub.com/covracer) in [astral-sh/ruff#4448 ##### Settings - Implement `--extend-fixable` option by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4297 - Support new `extend-per-file-ignores` setting by [@aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4265 ##### Bug Fixes - Fix RUF010 auto-fix with parenthesis by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4524 - Parenthesize more sub-expressions in f-string conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4535 - Fix false-positive for TRY302 if exception cause is given by [@153957](https://togithub.com/153957) in [astral-sh/ruff#4559 - Fix `# isort: split` comment detection in nested blocks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4584 - Avoid some false positives in dunder variable assigments by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4508 - Fix UP032 auto-fix with integers by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4525 - Improve reference resolution for deferred-annotations-within-classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4509 - Improve handling of `__qualname__`, `__module__`, and `__class__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4512 - Include empty success test in JUnit output by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4537 - Fix SIM110 and SIM111 ranges by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4545 - Ignore `#region` code folding marks in eradicate rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4546 - Avoid infinite loop for required imports with isort: off by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4581 - Make B007 fix relevance stricter by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4607 - Introduce `tab-size` to correcly calculate the line length with tabulations by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4167 - Visit `TypeVar` and `NewType` name arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4627 - Improve `Message` sorting performance by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4624 #### New Contributors - [@hoel-bagard](https://togithub.com/hoel-bagard) made their first contribution in [astral-sh/ruff#4516 - [@density](https://togithub.com/density) made their first contribution in [astral-sh/ruff#4517 - [@Mr-Pepe](https://togithub.com/Mr-Pepe) made their first contribution in [astral-sh/ruff#4540 - [@153957](https://togithub.com/153957) made their first contribution in [astral-sh/ruff#4559 - [@covracer](https://togithub.com/covracer) made their first contribution in [astral-sh/ruff#4448 **Full Changelog**: astral-sh/ruff@v0.0.269...v0.0.270 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Fix RUF010 auto-fix with parenthesis

0b6ef5d

MichaReiser reviewed May 19, 2023

View reviewed changes

crates/ruff/src/cst/matchers.rs Show resolved Hide resolved

MichaReiser reviewed May 19, 2023

View reviewed changes

crates/ruff/src/rules/ruff/rules/explicit_f_string_type_conversion.rs Show resolved Hide resolved

charliermarsh reviewed May 19, 2023

View reviewed changes

crates/ruff/src/rules/ruff/rules/explicit_f_string_type_conversion.rs Outdated Show resolved Hide resolved

charliermarsh added 2 commits May 19, 2023 14:52

Merge branch 'main' into fix-ruf010-auto-fix

cf832c3

One fix per diagnostic

b615525

charliermarsh enabled auto-merge (squash) May 19, 2023 18:58

charliermarsh added the bug Something isn't working label May 19, 2023

charliermarsh merged commit 03fb62c into astral-sh:main May 19, 2023
14 checks passed

JonathanPlasse deleted the fix-ruf010-auto-fix branch May 19, 2023 19:06

LotemAm mentioned this pull request May 21, 2023

RUF010 auto-fix only once per line #4567

Closed

chenrui333 mentioned this pull request May 24, 2023

ruff 0.0.270 Homebrew/homebrew-core#131915

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix RUF010 auto-fix with parenthesis #4524

Fix RUF010 auto-fix with parenthesis #4524

JonathanPlasse commented May 19, 2023 •

edited

github-actions bot commented May 19, 2023 •

edited

Fix RUF010 auto-fix with parenthesis #4524

Fix RUF010 auto-fix with parenthesis #4524

Conversation

JonathanPlasse commented May 19, 2023 • edited

github-actions bot commented May 19, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

JonathanPlasse commented May 19, 2023 •

edited

github-actions bot commented May 19, 2023 •

edited