Visit TypeVar and NewType name arguments
#4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/visit-name
branch
from
8289e3d
to
f657d30
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
charliermarsh
force-pushed
the
charlie/visit-name
branch
from
f657d30
to
9765ade
Compare
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
May 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.269` -> `^0.0.270` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.270`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.270) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.269...v0.0.270) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-bandit`] Implement `paramiko-call` (`S601`) by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4500 - \[`flake8-pyi`] Add autofix for PYI009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4583 - \[`flake8-pyi`] Implement `PYI013` by [@​density](https://togithub.com/density) in [astral-sh/ruff#4517 - \[`pylint`] Add `duplicate-value` (`W0130`) by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4515 - \[`pylint`] Add `named_expr_without_context` (`W0131`) by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4531 - \[`ruff`] Extend `RUF005` to recursive and literal-literal concatenations by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4557 - \[`ruff`] Make ambiguous-unicode detection sensitive to 'word' context by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4552 - \[`ruff`] Name ambiguous characters by [@​covracer](https://togithub.com/covracer) in [astral-sh/ruff#4448 ##### Settings - Implement `--extend-fixable` option by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4297 - Support new `extend-per-file-ignores` setting by [@​aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4265 ##### Bug Fixes - Fix RUF010 auto-fix with parenthesis by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4524 - Parenthesize more sub-expressions in f-string conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4535 - Fix false-positive for TRY302 if exception cause is given by [@​153957](https://togithub.com/153957) in [astral-sh/ruff#4559 - Fix `# isort: split` comment detection in nested blocks by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4584 - Avoid some false positives in dunder variable assigments by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4508 - Fix UP032 auto-fix with integers by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4525 - Improve reference resolution for deferred-annotations-within-classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4509 - Improve handling of `__qualname__`, `__module__`, and `__class__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4512 - Include empty success test in JUnit output by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4537 - Fix SIM110 and SIM111 ranges by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4545 - Ignore `#region` code folding marks in eradicate rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4546 - Avoid infinite loop for required imports with isort: off by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4581 - Make B007 fix relevance stricter by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4607 - Introduce `tab-size` to correcly calculate the line length with tabulations by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4167 - Visit `TypeVar` and `NewType` name arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4627 - Improve `Message` sorting performance by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4624 #### New Contributors - [@​hoel-bagard](https://togithub.com/hoel-bagard) made their first contribution in [astral-sh/ruff#4516 - [@​density](https://togithub.com/density) made their first contribution in [astral-sh/ruff#4517 - [@​Mr-Pepe](https://togithub.com/Mr-Pepe) made their first contribution in [astral-sh/ruff#4540 - [@​153957](https://togithub.com/153957) made their first contribution in [astral-sh/ruff#4559 - [@​covracer](https://togithub.com/covracer) made their first contribution in [astral-sh/ruff#4448 **Full Changelog**: astral-sh/ruff@v0.0.269...v0.0.270 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzUuOTguNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to allenporter/pyrainbird
that referenced
this pull request
May 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.269` -> `==0.0.270` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.270`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.270) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.269...v0.0.270) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-bandit`] Implement `paramiko-call` (`S601`) by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4500 - \[`flake8-pyi`] Add autofix for PYI009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4583 - \[`flake8-pyi`] Implement `PYI013` by [@​density](https://togithub.com/density) in [astral-sh/ruff#4517 - \[`pylint`] Add `duplicate-value` (`W0130`) by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4515 - \[`pylint`] Add `named_expr_without_context` (`W0131`) by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4531 - \[`ruff`] Extend `RUF005` to recursive and literal-literal concatenations by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4557 - \[`ruff`] Make ambiguous-unicode detection sensitive to 'word' context by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4552 - \[`ruff`] Name ambiguous characters by [@​covracer](https://togithub.com/covracer) in [astral-sh/ruff#4448 ##### Settings - Implement `--extend-fixable` option by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4297 - Support new `extend-per-file-ignores` setting by [@​aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4265 ##### Bug Fixes - Fix RUF010 auto-fix with parenthesis by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4524 - Parenthesize more sub-expressions in f-string conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4535 - Fix false-positive for TRY302 if exception cause is given by [@​153957](https://togithub.com/153957) in [astral-sh/ruff#4559 - Fix `# isort: split` comment detection in nested blocks by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4584 - Avoid some false positives in dunder variable assigments by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4508 - Fix UP032 auto-fix with integers by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4525 - Improve reference resolution for deferred-annotations-within-classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4509 - Improve handling of `__qualname__`, `__module__`, and `__class__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4512 - Include empty success test in JUnit output by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4537 - Fix SIM110 and SIM111 ranges by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4545 - Ignore `#region` code folding marks in eradicate rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4546 - Avoid infinite loop for required imports with isort: off by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4581 - Make B007 fix relevance stricter by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4607 - Introduce `tab-size` to correcly calculate the line length with tabulations by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4167 - Visit `TypeVar` and `NewType` name arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4627 - Improve `Message` sorting performance by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4624 #### New Contributors - [@​hoel-bagard](https://togithub.com/hoel-bagard) made their first contribution in [astral-sh/ruff#4516 - [@​density](https://togithub.com/density) made their first contribution in [astral-sh/ruff#4517 - [@​Mr-Pepe](https://togithub.com/Mr-Pepe) made their first contribution in [astral-sh/ruff#4540 - [@​153957](https://togithub.com/153957) made their first contribution in [astral-sh/ruff#4559 - [@​covracer](https://togithub.com/covracer) made their first contribution in [astral-sh/ruff#4448 **Full Changelog**: astral-sh/ruff@v0.0.269...v0.0.270 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuNCIsInVwZGF0ZWRJblZlciI6IjM1LjEwMi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
May 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.269` -> `==0.0.270` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.270`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.270) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.269...v0.0.270) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-bandit`] Implement `paramiko-call` (`S601`) by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4500 - \[`flake8-pyi`] Add autofix for PYI009 by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4583 - \[`flake8-pyi`] Implement `PYI013` by [@​density](https://togithub.com/density) in [astral-sh/ruff#4517 - \[`pylint`] Add `duplicate-value` (`W0130`) by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4515 - \[`pylint`] Add `named_expr_without_context` (`W0131`) by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4531 - \[`ruff`] Extend `RUF005` to recursive and literal-literal concatenations by [@​hoel-bagard](https://togithub.com/hoel-bagard) in [astral-sh/ruff#4557 - \[`ruff`] Make ambiguous-unicode detection sensitive to 'word' context by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4552 - \[`ruff`] Name ambiguous characters by [@​covracer](https://togithub.com/covracer) in [astral-sh/ruff#4448 ##### Settings - Implement `--extend-fixable` option by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4297 - Support new `extend-per-file-ignores` setting by [@​aacunningham](https://togithub.com/aacunningham) in [astral-sh/ruff#4265 ##### Bug Fixes - Fix RUF010 auto-fix with parenthesis by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4524 - Parenthesize more sub-expressions in f-string conversion by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4535 - Fix false-positive for TRY302 if exception cause is given by [@​153957](https://togithub.com/153957) in [astral-sh/ruff#4559 - Fix `# isort: split` comment detection in nested blocks by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4584 - Avoid some false positives in dunder variable assigments by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4508 - Fix UP032 auto-fix with integers by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4525 - Improve reference resolution for deferred-annotations-within-classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4509 - Improve handling of `__qualname__`, `__module__`, and `__class__` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4512 - Include empty success test in JUnit output by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4537 - Fix SIM110 and SIM111 ranges by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4545 - Ignore `#region` code folding marks in eradicate rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4546 - Avoid infinite loop for required imports with isort: off by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4581 - Make B007 fix relevance stricter by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4607 - Introduce `tab-size` to correcly calculate the line length with tabulations by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4167 - Visit `TypeVar` and `NewType` name arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4627 - Improve `Message` sorting performance by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#4624 #### New Contributors - [@​hoel-bagard](https://togithub.com/hoel-bagard) made their first contribution in [astral-sh/ruff#4516 - [@​density](https://togithub.com/density) made their first contribution in [astral-sh/ruff#4517 - [@​Mr-Pepe](https://togithub.com/Mr-Pepe) made their first contribution in [astral-sh/ruff#4540 - [@​153957](https://togithub.com/153957) made their first contribution in [astral-sh/ruff#4559 - [@​covracer](https://togithub.com/covracer) made their first contribution in [astral-sh/ruff#4448 **Full Changelog**: astral-sh/ruff@v0.0.269...v0.0.270 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNS4xMDIuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given
NewType(x, y), we weren't visitingxat all. I think this is becausexis typically a string constant (the name of theNewType), and we wanted to avoid treating it as a forward reference -- but we have support for that kind of traversal anyway.Closes #4623.