Properly group assignment targets #5728

MichaReiser · 2023-07-13T07:51:56Z

Summary

This PR implements the left-to-right expansion of assignment targets.

The way this is achieved is by nesting the assignment targets in groups, from left-to-right. This causes the left (outer most) groups to expand first.

Test Plan

I extended the snapshot tests and verified that the output matches black.

MichaReiser · 2023-07-13T07:52:08Z

Current dependencies on/for this PR:

main
- PR Properly group assignment targets #5728 👈
  - PR Cover Black's is_aritmetic_like formatting #5738
    - PR Parenthesize with statements #5758

This comment was auto-generated by Graphite.

github-actions · 2023-07-13T08:08:09Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.4±0.03ms     4.3 MB/sec    1.00      9.5±0.04ms     4.3 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.01ms     7.6 MB/sec    1.00      2.2±0.01ms     7.6 MB/sec
formatter/numpy/globals.py                 1.00    247.4±1.02µs    11.9 MB/sec    1.00    248.0±0.98µs    11.9 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.02ms     5.4 MB/sec    1.01      4.8±0.01ms     5.3 MB/sec
linter/all-rules/large/dataset.py          1.03     16.7±0.79ms     2.4 MB/sec    1.00     16.1±0.09ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.09      4.4±0.18ms     3.8 MB/sec    1.00      4.0±0.03ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    512.5±1.57µs     5.8 MB/sec    1.00    512.0±3.18µs     5.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.03ms     3.6 MB/sec    1.00      7.2±0.02ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.15ms     5.1 MB/sec    1.01      8.1±0.33ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1738.9±5.89µs     9.6 MB/sec    1.00   1730.3±5.73µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.01    198.3±0.63µs    14.9 MB/sec    1.00    196.9±0.95µs    15.0 MB/sec
linter/default-rules/pydantic/types.py     1.06      3.8±0.17ms     6.7 MB/sec    1.00      3.6±0.02ms     7.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      6.9±0.04ms     5.9 MB/sec    1.06      7.3±0.04ms     5.6 MB/sec
formatter/numpy/ctypeslib.py               1.00  1531.2±12.33µs    10.9 MB/sec    1.04  1587.5±13.39µs    10.5 MB/sec
formatter/numpy/globals.py                 1.00    165.4±3.74µs    17.8 MB/sec    1.03    170.2±3.66µs    17.3 MB/sec
formatter/pydantic/types.py                1.00      3.4±0.06ms     7.5 MB/sec    1.04      3.6±0.03ms     7.2 MB/sec
linter/all-rules/large/dataset.py          1.00     11.4±0.11ms     3.6 MB/sec    1.01     11.6±0.09ms     3.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.0±0.04ms     5.5 MB/sec    1.00      3.0±0.04ms     5.5 MB/sec
linter/all-rules/numpy/globals.py          1.00    317.1±5.36µs     9.3 MB/sec    1.01   319.5±11.20µs     9.2 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.2±0.05ms     4.9 MB/sec    1.01      5.2±0.08ms     4.9 MB/sec
linter/default-rules/large/dataset.py      1.00      5.9±0.04ms     6.9 MB/sec    1.00      5.9±0.03ms     6.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1211.4±8.83µs    13.7 MB/sec    1.01  1220.0±19.24µs    13.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    130.7±1.69µs    22.6 MB/sec    1.00    130.7±1.43µs    22.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.7±0.02ms     9.6 MB/sec    1.00      2.7±0.02ms     9.6 MB/sec

crates/ruff_python_formatter/resources/test/fixtures/ruff/statement/assign.py

konstin

i'm glad i gave up on this back then, this would have been way to hard, this now is a nice solution

konstin · 2023-07-13T09:22:06Z

crates/ruff_python_formatter/src/statement/stmt_assign.rs

+
+impl Format<PyFormatContext<'_>> for FormatTargets<'_> {
+    fn fmt(&self, f: &mut Formatter<PyFormatContext<'_>>) -> FormatResult<()> {
+        if let Some((first, rest)) = self.targets.split_first() {


nit: let-some-else-return-ok

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `0.0.278` -> `0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280)  #### What's Changed ##### Bug Fixes - Avoid collapsing `elif` and `else` branches during import sorting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5964 **Full Changelog**: astral-sh/ruff@v0.0.279...v0.0.280 ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

MichaReiser force-pushed the assignment-left-to-right branch from 0abcf73 to 7854933 Compare July 13, 2023 07:55

T-256 reviewed Jul 13, 2023

View reviewed changes

crates/ruff_python_formatter/resources/test/fixtures/ruff/statement/assign.py Outdated Show resolved Hide resolved

MichaReiser force-pushed the assignment-left-to-right branch from 7854933 to e76da77 Compare July 13, 2023 08:38

Properly group assignment targets

49a2664

MichaReiser force-pushed the assignment-left-to-right branch from e76da77 to 49a2664 Compare July 13, 2023 08:40

MichaReiser added the formatter Related to the formatter label Jul 13, 2023

konstin approved these changes Jul 13, 2023

View reviewed changes

MichaReiser mentioned this pull request Jul 13, 2023

Cover Black's is_aritmetic_like formatting #5738

Merged

MichaReiser merged commit 5dd5ee0 into main Jul 13, 2023
16 checks passed

MichaReiser deleted the assignment-left-to-right branch July 13, 2023 14:00

MichaReiser mentioned this pull request Jul 14, 2023

Parenthesize with statements #5758

Merged

evanrittenhouse pushed a commit to evanrittenhouse/ruff that referenced this pull request Jul 19, 2023

Properly group assignment targets (astral-sh#5728)

5d956f5

konstin pushed a commit that referenced this pull request Jul 19, 2023

Properly group assignment targets (#5728)

cf641bb

chenrui333 mentioned this pull request Jul 21, 2023

ruff 0.0.279 Homebrew/homebrew-core#137262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properly group assignment targets #5728

Properly group assignment targets #5728

MichaReiser commented Jul 13, 2023

MichaReiser commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading

konstin left a comment

konstin Jul 13, 2023

Properly group assignment targets #5728

Properly group assignment targets #5728

Conversation

MichaReiser commented Jul 13, 2023

Summary

Test Plan

MichaReiser commented Jul 13, 2023 • edited Loading

github-actions bot commented Jul 13, 2023 • edited Loading

PR Check Results

Ecosystem

Benchmark

Linux

Windows

konstin left a comment

Choose a reason for hiding this comment

konstin Jul 13, 2023

Choose a reason for hiding this comment

MichaReiser commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading