Expand RUF015 to include all expression types
#5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/ruf015
branch
2 times, most recently
from
7739374
to
635ef10
Compare
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+72, -0, 0 error(s)) airflow (+25, -0)
+ airflow/providers/amazon/aws/secrets/secrets_manager.py:221:38: RUF015 [*] Prefer `next(...)` over single element slice + airflow/providers/apache/hive/macros/hive.py:102:18: RUF015 [*] Prefer `next(iter(p.values()))` over single element slice + airflow/providers/cncf/kubernetes/triggers/pod.py:249:21: RUF015 [*] Prefer `next(...)` over single element slice + airflow/providers/google/cloud/operators/datafusion.py:47:22: RUF015 [*] Prefer `next(...)` over single element slice + airflow/serialization/serialized_objects.py:1136:47: RUF015 [*] Prefer `next(iter(_operator_links_source.items()))` over single element slice + dev/perf/scheduler_dag_execution_timing.py:83:19: RUF015 [*] Prefer `next(...)` over single element slice + kubernetes_tests/test_kubernetes_pod_operator.py:927:22: RUF015 [*] Prefer `next(...)` over single element slice + scripts/ci/pre_commit/pre_commit_version_heads_map.py:39:30: RUF015 [*] Prefer `next(...)` over single element slice + tests/decorators/test_python.py:465:22: RUF015 [*] Prefer `next(...)` over single element slice + tests/executors/test_kubernetes_executor.py:438:20: RUF015 [*] Prefer `next(iter(executor.event_buffer.values()))` over single element slice + tests/jobs/test_triggerer_job.py:556:35: RUF015 [*] Prefer `next(...)` over single element slice + tests/models/test_dagrun.py:1709:11: RUF015 [*] Prefer `next(i for i in tis if i.map_index == 0)` over single element slice + tests/operators/test_python.py:1184:32: RUF015 [*] Prefer `next(x for x in tis if x.task_id == "op1")` over single element slice + tests/operators/test_python.py:1215:32: RUF015 [*] Prefer `next(x for x in tis if x.task_id == "op1")` over single element slice + tests/operators/test_python.py:1242:32: RUF015 [*] Prefer `next(x for x in tis if x.task_id == "op1")` over single element slice + tests/operators/test_python.py:1277:32: RUF015 [*] Prefer `next(x for x in tis if x.task_id == "op1")` over single element slice + tests/providers/amazon/aws/secrets/test_systems_manager.py:160:27: RUF015 [*] Prefer `next(...)` over single element slice + tests/providers/google/cloud/operators/test_bigquery.py:678:27: RUF015 [*] Prefer `next(iter(simple_task.operator_extra_links))` over single element slice + tests/providers/google/cloud/operators/test_bigquery.py:716:27: RUF015 [*] Prefer `next(iter(simple_task.operator_extra_links))` over single element slice + tests/providers/qubole/operators/test_qubole.py:156:27: RUF015 [*] Prefer `next(iter(simple_task.operator_extra_links))` over single element slice + tests/system/providers/amazon/aws/utils/__init__.py:67:26: RUF015 [*] Prefer `next(...)` over single element slice + tests/test_utils/providers.py:56:19: RUF015 [*] Prefer `next(...)` over single element slice + tests/www/test_utils.py:436:15: RUF015 [*] Prefer `next(...)` over single element slice + tests/www/views/test_views_acl.py:339:16: RUF015 [*] Prefer `next(iter(resp.json.items()))` over single element slice + tests/www/views/test_views_base.py:254:16: RUF015 [*] Prefer `next(iter(resp.json.items()))` over single element slice bokeh (+7, -0)
+ src/bokeh/core/enums.py:362:41: RUF015 [*] Prefer `next(iter(zip(*_hatch_patterns)))` over single element slice + src/bokeh/embed/standalone.py:125:22: RUF015 [*] Prefer `next(...)` over single element slice + src/bokeh/io/notebook.py:110:24: RUF015 [*] Prefer `next(...)` over single element slice + src/bokeh/plotting/_legends.py:55:20: RUF015 [*] Prefer `next(iter(legend_kwarg.items()))` over single element slice + tests/unit/bokeh/embed/test_standalone.py:412:20: RUF015 [*] Prefer `next(...)` over single element slice + tests/unit/bokeh/embed/test_util__embed.py:512:15: RUF015 [*] Prefer `next(iter(docs_json.values()))` over single element slice + tests/unit/bokeh/embed/test_util__embed.py:524:15: RUF015 [*] Prefer `next(iter(docs_json.values()))` over single element slice scikit-build (+4, -0)
+ skbuild/cmaker.py:753:20: RUF015 [*] Prefer `next(...)` over single element slice + skbuild/command/egg_info.py:27:32: RUF015 [*] Prefer `next(...)` over single element slice + skbuild/command/egg_info.py:28:41: RUF015 [*] Prefer `next(...)` over single element slice + tests/test_setup.py:778:22: RUF015 [*] Prefer `next(...)` over single element slice zulip (+36, -0)
+ analytics/management/commands/populate_analytics_db.py:158:67: RUF015 [*] Prefer `next(iter(fixture_data.values()))` over single element slice + corporate/views/portico.py:136:37: RUF015 [*] Prefer `next(...)` over single element slice + tools/tests/test_zulint_custom_rules.py:71:32: RUF015 [*] Prefer `next(...)` over single element slice + zerver/lib/event_schema.py:458:12: RUF015 [*] Prefer `next(iter(event["presence"].keys()))` over single element slice + zerver/lib/event_schema.py:460:12: RUF015 [*] Prefer `next(iter(event["presence"].values()))` over single element slice + zerver/lib/markdown/__init__.py:1155:26: RUF015 [*] Prefer `next(iter(uncle.iter(tag="a")))` over single element slice + zerver/lib/test_classes.py:1545:16: RUF015 [*] Prefer `next(r for r in data if r["id"] == db_id)` over single element slice + zerver/openapi/python_examples.py:626:25: RUF015 [*] Prefer `next(...)` over single element slice + zerver/openapi/python_examples.py:629:28: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_auth_backends.py:3701:29: RUF015 [*] Prefer `next(iter(oidc_setting_dict.values()))` over single element slice + zerver/tests/test_auth_backends.py:3751:27: RUF015 [*] Prefer `next(iter(mock_oidc_setting_dict.values()))` over single element slice + zerver/tests/test_auth_backends.py:3766:27: RUF015 [*] Prefer `next(iter(mock_oidc_setting_dict.values()))` over single element slice + zerver/tests/test_event_system.py:588:30: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_event_system.py:797:26: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_event_system.py:808:26: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_events.py:1083:26: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_events.py:1094:26: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_gitter_importer.py:103:45: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_gitter_importer.py:98:41: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_logging_handlers.py:69:16: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_message_fetch.py:2811:27: RUF015 [*] Prefer `next(...)` over single element slice + zerver/tests/test_message_send.py:2001:31: RUF015 [*] Prefer `next(iter(recent_conversations.values()))` over single element slice + zerver/tests/test_message_send.py:590:31: RUF015 [*] Prefer `next(iter(recent_conversations.values()))` over single element slice + zerver/tests/test_message_send.py:591:24: RUF015 [*] Prefer `next(iter(recent_conversations.keys()))` over single element slice + zerver/tests/test_message_send.py:615:31: RUF015 [*] Prefer `next(iter(recent_conversations.values()))` over single element slice + zerver/tests/test_message_send.py:616:24: RUF015 [*] Prefer `next(iter(recent_conversations.keys()))` over single element slice + zerver/tests/test_users.py:2161:27: RUF015 [*] Prefer `next(...)` over single element slice + zerver/views/realm_emoji.py:43:18: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zerver/views/realm_icon.py:22:17: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zerver/views/realm_logo.py:28:17: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zerver/views/upload.py:272:17: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zerver/views/user_settings.py:366:17: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zerver/views/users.py:417:21: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zerver/views/users.py:559:21: RUF015 [*] Prefer `next(iter(request.FILES.values()))` over single element slice + zproject/backends.py:2847:40: RUF015 [*] Prefer `next(...)` over single element slice + zproject/backends.py:2874:27: RUF015 [*] Prefer `next(...)` over single element slice
BenchmarkLinuxWindows |
|
I need to change the diagnostic to avoid including the entire snippet if it's multi-line. |
|
It's a lot of new violations but they generally look correct to me. |
charliermarsh
force-pushed
the
charlie/ruf015
branch
from
635ef10
to
6f0725c
Compare
|
Sorry for the noise, but isn't it possible to reduce |
|
Good point! |
charliermarsh
force-pushed
the
charlie/ruf015
branch
3 times, most recently
from
4079089
to
46a037b
Compare
charliermarsh
force-pushed
the
charlie/ruf015
branch
from
46a037b
to
f475774
Compare
|
@zanieb - Do you mind taking a look at this one? I'd love to get more sets of eyes on whether this is a safe / correct refactor from the Python perspective. |
charliermarsh
force-pushed
the
charlie/ruf015
branch
from
f475774
to
3826e04
Compare
MichaReiser
reviewed
Jul 20, 2023
crates/ruff/src/rules/ruff/rules/unnecessary_iterable_allocation_for_first_element.rs
Show resolved
Hide resolved
crates/ruff/src/rules/ruff/rules/unnecessary_iterable_allocation_for_first_element.rs
Outdated
Show resolved
Hide resolved
crates/ruff/src/rules/ruff/rules/unnecessary_iterable_allocation_for_first_element.rs
Outdated
Show resolved
Hide resolved
crates/ruff/src/rules/ruff/rules/unnecessary_iterable_allocation_for_first_element.rs
Outdated
Show resolved
Hide resolved
|
I've given the ecosystem changes a look and thought about the rule a bit. I can't really think of any downsides here other than that it's a little advanced for most users in comparison with |
charliermarsh
force-pushed
the
charlie/ruf015
branch
from
3826e04
to
932575d
Compare
jankatins
added a commit
to jankatins/pr-workflow-example
that referenced
this pull request
Jul 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `0.0.278` -> `0.0.280` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279) <!-- Release notes generated using configuration in .github/release.yml at v0.0.279 --> #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@​LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@​density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@​density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@​density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@​density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@​guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@​lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@​sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@​konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@​eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@​guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@​odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@​DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@​LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
renovate bot
added a commit
to allenporter/pyrainbird
that referenced
this pull request
Jul 23, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279) <!-- Release notes generated using configuration in .github/release.yml at v0.0.279 --> #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@​LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@​density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@​density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@​density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@​density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@​guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@​lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@​sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@​konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@​eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@​guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@​odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@​DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@​LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
Jul 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) <!-- Release notes generated using configuration in .github/release.yml at v0.0.280 --> #### What's Changed ##### Bug Fixes - Avoid collapsing `elif` and `else` branches during import sorting by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5964 **Full Changelog**: astral-sh/ruff@v0.0.279...v0.0.280 ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279) <!-- Release notes generated using configuration in .github/release.yml at v0.0.279 --> #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@​LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@​density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@​density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@​density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@​density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@​guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@​lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@​tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@​sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@​konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@​eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@​guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@​odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@​DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@​LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now allow RUF015 to fix cases like:
Further, we fix generators like:
By rewriting to
next(iter(i + 1 for i in x)).I've retained the special-case that rewrites
[i for i in x][0]tonext(iter(x)).Closes #5764.