Formatter: Implicit concatenation in compare expressions

[MichaReiser]

Summary

This PR implements the logic for breaking implicit concatenated strings before compare expressions by building on top of #7145

The main change is a new BinaryLike enum that has the BinaryExpression and CompareExpression variants. Supporting both variants requires some downstream changes but doesn't introduce any new concepts.

Test Plan

I added a few more tests. The compatibility improvements are minor but we now perfectly match black on twine 🥳

PR

project	similarity index	total files	changed files
cpython	0.76083	1789	1632
django	0.99966	2760	58
transformers	0.99928	2587	454
twine	1.00000	33	0
typeshed	0.99978	3496	2173
warehouse	0.99824	648	22
zulip	0.99948	1437	28

Base

project	similarity index	total files	changed files
cpython	0.76083	1789	1633
django	0.99966	2760	58
transformers	0.99928	2587	454
twine	0.99982	33	1
typeshed	0.99978	3496	2173
warehouse	0.99823	648	23
zulip	0.99948	1437	28

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Split implicit concatenated strings before binary expressions #7145
    • PR Formatter: Implicit concatenation in compare expressions #7193 👈
      • PR Add FString support to binary like formatting #7215
        • PR Add PreviewMode option to formatter #7217
          • PR Extract string part and normalized string #7219
            • PR Introduce StringContinuation data structure #7242
              • PR POC of Black's string preview style formatting #7567

This comment was auto-generated by Graphite.

[MichaReiser]

This is mostly moved from flatten_binary_expression except that it now supports compare expressions too

[konstin]

100% on twine!

[MichaReiser]

Merge Activity

• Sep 8, 5:32 AM: @MichaReiser merged this pull request with Graphite.