Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC of Black's string preview style formatting #7567

Closed
wants to merge 1 commit into from

Conversation

MichaReiser
Copy link
Member

Summary

Test Plan

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 21, 2023

CodSpeed Performance Report

Merging #7567 will degrade performances by 59.85%

Comparing string-preview-style (5d2513e) with create-string-continuation (272306b)

Summary

❌ 6 regressions
✅ 19 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark create-string-continuation string-preview-style Change
formatter[numpy/globals.py] 1.1 ms 2.7 ms -59.85%
formatter[unicode/pypinyin.py] 3.4 ms 3.6 ms -6.76%
linter/all-rules[large/dataset.py] 164 ms 168.1 ms -2.41%
formatter[large/dataset.py] 52.3 ms 54.9 ms -4.69%
formatter[numpy/ctypeslib.py] 9.9 ms 14.4 ms -31.03%
formatter[pydantic/types.py] 19.1 ms 22.7 ms -15.93%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant