-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PreviewMode option to formatter #7217
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
c1cc7cd
to
193a218
Compare
CodSpeed Performance ReportMerging #7217 will degrade performances by 2.54%Comparing Summary
Benchmarks breakdown
|
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
a4b4a31
to
1d0d8cc
Compare
193a218
to
0682684
Compare
1d0d8cc
to
3e5f82e
Compare
f61f478
to
e601118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is preview mode a global only flag or can it also be hierarchical?
I would expect it to be hierarchical the same way as any other configuration option. CC: @zanieb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to approve
IMO it should match the behavior of other settings (and I assume it will by default based on the implementation): hierarchical, but providing it on the command-line overrides it for all files. |
e9fe660
to
259ac02
Compare
e601118
to
814f4dc
Compare
259ac02
to
14c775c
Compare
Merge Activity
|
814f4dc
to
65c5853
Compare
Summary
This PR adds the
--preview
and--no-preview
options to theformat
command (hidden) and passes it through to the formatte.Test Plan
I added the
dbg(f.options().preview())
statement inFormatNodeRule::fmt
and verified that the option gets correctly passed to the formatter.