Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid locking projects without source #381

Closed
T-256 opened this issue Jul 19, 2023 · 2 comments
Closed

Avoid locking projects without source #381

T-256 opened this issue Jul 19, 2023 · 2 comments

Comments

@T-256
Copy link
Contributor

T-256 commented Jul 19, 2023

  1. rye init test && cd test
  2. remove src folder

The suggestion is rye lock should not contain -e file:. line.

@T-256 T-256 changed the title Skip projects without source Avoid locking projects without source Jul 19, 2023
@bluss
Copy link
Contributor

bluss commented Jul 19, 2023

don't you want an explicit marker (like workspace-only) for this? You can have a python library without a src directory, have the files somewhere else.

@T-256
Copy link
Contributor Author

T-256 commented Jul 19, 2023

don't you want an explicit marker (like workspace-only) for this?

it's differed from workspace-only. Currently with above steps, the build backend (e.g. hatchling) builds the project successfully, but actually it's empty package (not importable) and only package-info folder exists in site-packages.

You can have a python library without a src directory, have the files somewhere else.

Here I don't mean only src folder, it's just example for known build backends that contain source code in src/{project} folder. also, the main work here is to detect empty packages before (or after?) building them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants