Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid taking GitHub fast path for git clones #3952

Open
ibraheemdev opened this issue May 31, 2024 · 5 comments
Open

Avoid taking GitHub fast path for git clones #3952

ibraheemdev opened this issue May 31, 2024 · 5 comments
Labels
performance Potential performance improvement

Comments

@ibraheemdev
Copy link
Member

Avoid using github_fast_path for the initial clone of a repository. This would require using git clone instead of git init + git fetch, and using the --branch argument to resolve refspecs.

@ibraheemdev ibraheemdev added the performance Potential performance improvement label May 31, 2024
@charliermarsh
Copy link
Member

What's the motivation?

@samypr100
Copy link
Contributor

There were also some discussions about other approaches in #3287

@ibraheemdev
Copy link
Member Author

That discussion is mostly unrelated to this. The GitHub fast path primarily tells us if the commit we have is up to date, so we shouldn't need to take it for the initial clone.

@charliermarsh
Copy link
Member

Don't we need to figure out the precise commit from (e.g.) the branch / tag though? I thought we skipped this anyway if we had a precise commit already, and that the fast path was mostly for that operation.

@ibraheemdev
Copy link
Member Author

ibraheemdev commented Jun 4, 2024

I don't see an early return in github_fast_path unless we find the local repo is up to date, and the resulting oid is used pretty rarely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Potential performance improvement
Projects
None yet
Development

No branches or pull requests

3 participants