Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename prev_state_root in DoBlockRequest to prev_block_hash #49

Closed
noot opened this issue Jun 7, 2023 · 1 comment · Fixed by #136
Closed

rename prev_state_root in DoBlockRequest to prev_block_hash #49

noot opened this issue Jun 7, 2023 · 1 comment · Fixed by #136
Labels
good-first-issue Good for newcomers proto pertaining to the Astria Protobuf spec

Comments

@noot
Copy link
Collaborator

noot commented Jun 7, 2023

currently, the gRPC method DoBlockRequest has a field called prev_state_root but what's actually passed here is the parent block hash, and should be called prev_block_hash.
@noot noot added good-first-issue Good for newcomers proto pertaining to the Astria Protobuf spec labels Jun 7, 2023
@akansjain
Copy link

Hey @noot ,
I would like to work on this issue.

@joroshiba joroshiba linked a pull request Jun 12, 2023 that will close this issue
renamed prev_state_root in DoBlockRequest to prev_block_hash #55
Closed
@noot noot mentioned this issue Jul 4, 2023
Merged
@noot noot closed this as completed in #136 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers proto pertaining to the Astria Protobuf spec
Projects
None yet
Milestone
No milestone
2 participants
@noot @akansjain