Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window receiving focus may not be the right one #4

Closed
apm256 opened this issue Dec 2, 2014 · 8 comments
Closed

window receiving focus may not be the right one #4

apm256 opened this issue Dec 2, 2014 · 8 comments
Labels

Comments

@apm256
Copy link

apm256 commented Dec 2, 2014

When I open a new window with 'O', and use 'F' or 'L' in the first one, the text field opens itself in the second window, not in the first one as expected.

By the way, I've tested astroid for a few days, and I'm very pleased with it.

@gauteh
Copy link
Member

gauteh commented Dec 2, 2014

Excerpts from apm256's message of December 2, 2014 12:52:

When I open a new window with 'O', and use 'F' or 'L' in the first one, the text field opens itself in the second window, not in the first one as expected.

What desktop environment / window manager are you using? I am currently detecting
focus-in and focus-out events to determine which window should grab the
keyboard. Is this in edit-mode with gvim open?

By the way, I tested astroid for a few days, and I'm very pleased with it.

Nice!

@gauteh gauteh added the bug label Dec 2, 2014
@apm256
Copy link
Author

apm256 commented Dec 2, 2014

No gvim open here. I'm using herbstluftwm. (I will test later on another WM, just in case.)

@gauteh
Copy link
Member

gauteh commented Dec 2, 2014

Excerpts from apm256's message of December 2, 2014 13:29:

No gvim open here. I'm using herbstluftwm. (I will test later on another WM, just in case.)

Ok, I added some debug output in 9b97015 so that you can keep track of
which window gets/has/looses focus. I've been testing on openbox and i3.

@apm256
Copy link
Author

apm256 commented Dec 2, 2014

I experimented a bit further with herbstluftwm. By default, hwm does not give focus to new windows. When I override this setting for astroid:

herbstclient rule class~'[Aa]stroid' focus=on

...the wrong behavior disappears.

@gauteh
Copy link
Member

gauteh commented Dec 2, 2014

Excerpts from apm256's message of December 2, 2014 16:32:

I experimented a bit further with herbstluftwm. By default, hwm does not give focus to new windows. When I override this setting for astroid:

herbstclient rule class~'[Aa]stroid' focus=on

...the wrong behavior disappears.

Nice catch. I'll check if I assume somewhere that the new window is given
focus.

@gauteh
Copy link
Member

gauteh commented Dec 2, 2014

Excerpts from Gaute Hope's message of December 2, 2014 16:38:

Excerpts from apm256's message of December 2, 2014 16:32:

I experimented a bit further with herbstluftwm. By default, hwm does not give focus to new windows. When I override this setting for astroid:

herbstclient rule class~'[Aa]stroid' focus=on

...the wrong behavior disappears.

Nice catch. I'll check if I assume somewhere that the new window is given
focus.

Seems like I did an unconditional grab_modal on new windows, it should
be fixed in e017fd8. Let me know if there is a difference.

@apm256
Copy link
Author

apm256 commented Dec 2, 2014

nice! Everything seems to work, now.

@gauteh
Copy link
Member

gauteh commented Dec 2, 2014

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants