Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping shells for OnionPartitioning #25

Open
JulienPeloton opened this issue Jun 1, 2018 · 2 comments
Open

Overlapping shells for OnionPartitioning #25

JulienPeloton opened this issue Jun 1, 2018 · 2 comments
Assignees

Comments

@JulienPeloton
Copy link
Member

JulienPeloton commented Jun 1, 2018

As of now, the shells use to define the OnionPartitioning are non-overlapping.
Cross-matching 2 data sets with this implementation will unavoidably lead to miss pairs at the borders.
One idea would be to make overlapping shells as

// To be in OnionPartitioning.scala, LinearOnionPartitioning(...)
// Add overlapping shells -- e.g. 1% (to be defined)
val extension : Double = 0.01
for (pos <- 0 to numPartitions - 1) {
  // Inner radius must be greater than 0 (or equal to 0)
  val innerRadius = math.max(0.0, pos * dZ * (1 - extension))
  val outerRadius = (pos + 1) * dZ * (1 + extension)
  
  val shell = new ShellEnvelope(center, innerRadius, outerRadius)
  grids += shell
}
@ChrisArnault
Copy link
Contributor

Then this algo should include the rejection of the duplicates between shells

@JulienPeloton
Copy link
Member Author

Not directly this algo (which just defines the grid elements), but I agree we should include in PixelCrossMatch the required method to filter cross-match duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants