Bug: Unit confusion (seconds vs microseconds) in microseconds field of Keep Alive request (Client#alive())

[enricovittorini]

scte104/src/client.ts

Line 78 in 51a6dd3

let microseconds = (elapsed - seconds) * 1000;

hi! can you please explain the above line of code?
let microseconds = (elapsed - seconds) * 1000;
here is seems that you are doing the difference between something in milliseconds (elapsed) and something in seconds (seconds).
Am i missing something?

thanks!

---

Bug: Unit confusion in microseconds field of Time structure delivered by Client#alive() in keep alive requests as specified in SCTE 104 2019 section 9.2.1
Impact: Affects @/scte104@1.0.0 and earlier

[rezonant]

Fixed in @/scte104@1.0.1. Affects @/scte104@1.0.0 and all earlier versions.

[rezonant]

Good catch @enricovittorini ! You can find the fixed logic here:

scte104/src/client.ts

Line 78 in 24ac153

let microseconds = (elapsed - seconds*1000) * 1000;

I believe this addresses the issue, let me know if you see anything wrong with it.