dont write workload identity to yaml file on deployment inspect (#1565)

* dont write workload identity to yaml file on deployment inspect

* fix unit tests

---------

Co-authored-by: Julian LaNeve <lanevejulian@gmail.com>

cloud/deployment/inspect/inspect.go

@@ -53,7 +53,7 @@ type deploymentConfig struct {
 	ResourceQuotaCPU      string `mapstructure:"resource_quota_cpu,omitempty" yaml:"resource_quota_cpu,omitempty" json:"resource_quota_cpu,omitempty"`
 	ResourceQuotaMemory   string `mapstructure:"resource_quota_memory,omitempty" yaml:"resource_quota_memory,omitempty" json:"resource_quota_memory,omitempty"`
 	DefaultWorkerType     string `mapstructure:"default_worker_type,omitempty" yaml:"default_worker_type,omitempty" json:"default_worker_type,omitempty"`
-	WorkloadIdentity      string `mapstructure:"workload_identity,omitempty" yaml:"workload_identity,omitempty" json:"workload_identity,omitempty"`
+	WorkloadIdentity      string `mapstructure:"workload_identity" yaml:"workload_identity" json:"workload_identity"` // intentionally removing omitempty so we have an empty placeholder for this value if someone wants to set it
 }
 
 type Workerq struct {
@@ -255,9 +255,6 @@ func getDeploymentConfig(coreDeploymentPointer *astroplatformcore.Deployment, pl
 	if coreDeployment.Region != nil {
 		deploymentMap["region"] = *coreDeployment.Region
 	}
-	if coreDeployment.WorkloadIdentity != nil {
-		deploymentMap["workload_identity"] = *coreDeployment.WorkloadIdentity
-	}
 
 	return deploymentMap, nil
 }

cloud/deployment/inspect/inspect_test.go

@@ -467,7 +467,6 @@ func TestGetDeploymentConfig(t *testing.T) {
 			Region:            *sourceDeployment.Region,
 			DeploymentType:    string(*sourceDeployment.Type),
 			CloudProvider:     *sourceDeployment.CloudProvider,
-			WorkloadIdentity:  *sourceDeployment.WorkloadIdentity,
 			IsDevelopmentMode: *sourceDeployment.IsDevelopmentMode,
 		}
 		rawDeploymentConfig, err := getDeploymentConfig(&sourceDeployment, mockPlatformCoreClient)
@@ -743,6 +742,7 @@ func TestFormatPrintableDeployment(t *testing.T) {
         deployment_type: HYBRID
         cloud_provider: ""
         region: ""
+        workload_identity: ""
     worker_queues:
         - name: default
           max_worker_count: 130
@@ -831,6 +831,7 @@ func TestFormatPrintableDeployment(t *testing.T) {
         default_task_pod_memory: "1"
         resource_quota_cpu: "1"
         resource_quota_memory: "1"
+        workload_identity: ""
     worker_queues:
         - name: default
           max_worker_count: 130
@@ -1015,7 +1016,8 @@ func TestFormatPrintableDeployment(t *testing.T) {
             "workspace_name": "test-ws",
             "deployment_type": "HYBRID",
             "cloud_provider": "",
-            "region": ""
+            "region": "",
+            "workload_identity": ""
         },
         "worker_queues": [],
         "alert_emails": [