Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row count implementation for table missing #1073

Closed
sunank200 opened this issue Oct 17, 2022 · 0 comments · Fixed by #1074
Closed

Row count implementation for table missing #1073

sunank200 opened this issue Oct 17, 2022 · 0 comments · Fixed by #1074
Assignees
@pankajastro
Labels
feature New feature or request product/python-sdk Label describing products
Milestone
1.2.0

Comments

@sunank200
Copy link
Contributor

Describe the bug
Row count for BaseTable class is missing.

Expected behavior
Add the implementation for row count for BaseTable.
@sunank200 sunank200 added this to the 1.2.0 milestone Oct 17, 2022
@pankajastro pankajastro mentioned this issue Oct 17, 2022
Merged
2 tasks
@pankajastro pankajastro added product/python-sdk Label describing products feature New feature or request labels Oct 18, 2022
pankajastro added a commit that referenced this issue Oct 18, 2022
@pankajastro @pre-commit-ci
Add row_count on Table (#1074)
e63a3ce 
# Description
closes: #1073

Add row_count property in BaseTable class. 
Fixed the extractor tests accordingly 

## What is the current behavior?
We do not have a way to get table row count


## What is the new behavior?
Add row_count property in BaseTable class


## Does this introduce a breaking change?
No

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pankajastro pankajastro mentioned this issue Oct 18, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pankajastro pankajastro

Labels
feature New feature or request product/python-sdk Label describing products
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Add row_count on Table astronomer/astro-sdk
2 participants
@sunank200 @pankajastro