Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row_count on Table #1074

Merged
merged 8 commits into from
Oct 18, 2022
Merged

Add row_count on Table #1074

merged 8 commits into from
Oct 18, 2022

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Oct 17, 2022

Description

closes: #1073

Add row_count property in BaseTable class.
Fixed the extractor tests accordingly

What is the current behavior?

We do not have a way to get table row count

What is the new behavior?

Add row_count property in BaseTable class

Does this introduce a breaking change?

No

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 97.16% // Head: 94.25% // Decreases project coverage by -2.91% ⚠️

Coverage data is based on head (378bb61) compared to base (03fecd6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   97.16%   94.25%   -2.92%     
==========================================
  Files          11       64      +53     
  Lines         318     2839    +2521     
  Branches       30      312     +282     
==========================================
+ Hits          309     2676    +2367     
- Misses          5      112     +107     
- Partials        4       51      +47     
Impacted Files Coverage Δ
python-sdk/src/astro/table.py 100.00% <100.00%> (ø)
sql-cli/sql_cli/project.py 85.41% <0.00%> (-14.59%) ⬇️
sql-cli/sql_cli/configuration.py 100.00% <0.00%> (ø)
python-sdk/src/astro/sql/__init__.py 90.00% <0.00%> (ø)
python-sdk/src/astro/utils/typing_compat.py 66.66% <0.00%> (ø)
python-sdk/src/astro/airflow/datasets.py 85.71% <0.00%> (ø)
...thon-sdk/src/astro/sql/operators/base_decorator.py 94.16% <0.00%> (ø)
python-sdk/src/astro/settings.py 100.00% <0.00%> (ø)
python-sdk/src/astro/sql/operators/drop.py 100.00% <0.00%> (ø)
python-sdk/src/astro/lineage/extractor.py 100.00% <0.00%> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Can we resolve the comments, please?

python-sdk/src/astro/table.py Outdated Show resolved Hide resolved
python-sdk/tests/utils/test_table.py Show resolved Hide resolved
@pankajastro pankajastro merged commit e63a3ce into main Oct 18, 2022
@pankajastro pankajastro deleted the table_row_count branch October 18, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row count implementation for table missing
4 participants