-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row_count
on Table
#1074
Add row_count
on Table
#1074
Conversation
Codecov ReportBase: 97.16% // Head: 94.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 97.16% 94.25% -2.92%
==========================================
Files 11 64 +53
Lines 318 2839 +2521
Branches 30 312 +282
==========================================
+ Hits 309 2676 +2367
- Misses 5 112 +107
- Partials 4 51 +47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d943a2a
to
c187b0f
Compare
c187b0f
to
4b7fa36
Compare
6295fda
to
596e76a
Compare
a17d337
to
2f22681
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Can we resolve the comments, please?
20ed074
to
74899b1
Compare
for more information, see https://pre-commit.ci
Description
closes: #1073
Add row_count property in BaseTable class.
Fixed the extractor tests accordingly
What is the current behavior?
We do not have a way to get table row count
What is the new behavior?
Add row_count property in BaseTable class
Does this introduce a breaking change?
No
Checklist