Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example_amazon_s3_snowflake_transform dag #293

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

utkarsharma2
Copy link
Collaborator

@utkarsharma2 utkarsharma2 commented Apr 6, 2022

Closes: #136

example_amazon_s3_snowflake_transform.py was using prepopulated tables in the snowflake database.

Removed dependency from prepopulated tables by using the load_file operator.

@utkarsharma2 utkarsharma2 marked this pull request as draft April 6, 2022 13:57
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #293 (9738d32) into main (f9a50f4) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   92.05%   92.27%   +0.22%     
==========================================
  Files          35       35              
  Lines        1535     1527       -8     
  Branches      268      268              
==========================================
- Hits         1413     1409       -4     
+ Misses         90       86       -4     
  Partials       32       32              
Impacted Files Coverage Δ
src/astro/sql/operators/sql_decorator.py 92.14% <ø> (+0.86%) ⬆️
src/astro/sql/parsers/sql_directory_parser.py 94.39% <ø> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba19088...9738d32. Read the comment docs.

@utkarsharma2 utkarsharma2 marked this pull request as ready for review April 6, 2022 14:13
@kaxil kaxil changed the title Modified dag to create tables and then use them. Enhance example_amazon_s3_snowflake_transform dag Apr 6, 2022
@kaxil kaxil changed the title Enhance example_amazon_s3_snowflake_transform dag Improve example_amazon_s3_snowflake_transform dag Apr 6, 2022
@utkarsharma2 utkarsharma2 merged commit 488361f into main Apr 8, 2022
@utkarsharma2 utkarsharma2 deleted the Refactor_SF_testcase branch April 8, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor tests which rely on pre-populated Snowflake database
3 participants