Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create BaseDatabase and SqliteDatabase #340

Closed
4 tasks done
tatiana opened this issue May 3, 2022 · 0 comments · Fixed by #320
Closed
4 tasks done

Create BaseDatabase and SqliteDatabase #340

tatiana opened this issue May 3, 2022 · 0 comments · Fixed by #320
Labels
refactor Refactor code base, without introducing new features

Comments

@tatiana
Copy link
Collaborator

tatiana commented May 3, 2022 •
edited
Loading

Describe the context
This task is part of the Astro Python SDK refactor.

Acceptance criteria

  • Create BaseDatabase, defining its interfaces
  • Create SqliteDatabase, defining its interfaces
  • Use importlib to import modules so they do not need to be imported unless used by end-users
  • Create Table class, with a minimum interface, to be used by end-users
@tatiana tatiana mentioned this issue May 3, 2022
Merged
@tatiana tatiana added the refactor Refactor code base, without introducing new features label May 3, 2022
@tatiana tatiana closed this as completed May 3, 2022
This was referenced May 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor code base, without introducing new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: base & SQLite database classes astronomer/astro-sdk
1 participant
@tatiana