Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files for creation of new target catalogs. #61

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

delucchi-cmu
Copy link
Contributor

This is a prefactor for issue #47 (create column-level indexes).

The new pipeline will reside in the import package, with its own map reduce and supporting files.

@delucchi-cmu delucchi-cmu requested review from a team and OliviaLynn and removed request for a team April 3, 2023 12:31
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #61 (b9a5c73) into main (8328c4e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files           9       10    +1     
  Lines         409      409           
=======================================
  Hits          402      402           
  Misses          7        7           
Impacted Files Coverage Δ
src/hipscat_import/__init__.py 100.00% <ø> (ø)
src/hipscat_import/catalog/file_readers.py 100.00% <ø> (ø)
src/hipscat_import/catalog/map_reduce.py 100.00% <ø> (ø)
src/hipscat_import/catalog/resume_files.py 100.00% <ø> (ø)
src/hipscat_import/catalog/__init__.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/arguments.py 96.80% <100.00%> (ø)
...c/hipscat_import/catalog/command_line_arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/run_import.py 100.00% <100.00%> (ø)
src/hipscat_import/control.py 80.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, always a fan of an elegant prefactor!

@delucchi-cmu delucchi-cmu merged commit 343431e into main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants