Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid timeout when checking for stale issues/pull requests #55

Merged
merged 2 commits into from
May 4, 2018

Conversation

astrofrog
Copy link
Member

As described in https://librenepal.com/article/flask-and-heroku-timeout/, this should prevent timeouts as well as return the status of the checks to Travis

@pllim
Copy link
Member

pllim commented Nov 21, 2017

This broke the tests. 😢

@bsipocz
Copy link
Member

bsipocz commented Nov 21, 2017

Wow, this really messed up the tests. Could you please fix them?

@astrofrog
Copy link
Member Author

I'll get to it soon...

@pllim
Copy link
Member

pllim commented Mar 23, 2018

(Would be nice to resolve this one before refactoring for #2, #58, and such.)

@coveralls
Copy link

coveralls commented May 3, 2018

Coverage Status

Coverage increased (+0.2%) to 85.451% when pulling 88edd83 on astrofrog:avoid-timeout into 2306014 on astropy:master.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need a rebase and reinspect CI results after merging #70.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit 98356b6 into astropy:master May 4, 2018
@pllim pllim deleted the avoid-timeout branch May 4, 2018 01:34
astrofrog pushed a commit to OpenAstronomy/baldrick that referenced this pull request Jul 23, 2018
Avoid timeout when checking for stale issues/pull requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants