Merge pull request #199 from dpshelio/doctestOut

making sure run commands returns 1 if fails
astropy · Nov 20, 2015 · 988a83e · 988a83e
1 parent 6e9f1e7
commit 988a83e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,7 +4,9 @@ astropy-helpers Changelog
 1.0.6 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Fixed bug where running ``./setup.py build_sphinx`` could return successfully
+  even when the build was not successful (and should have returned a non-zero
+  error code). [#199]
 
 
 1.0.5 (2015-10-02)

diff --git a/astropy_helpers/commands/build_sphinx.py b/astropy_helpers/commands/build_sphinx.py
@@ -215,6 +215,7 @@ def run(self):
         else:
             log.warn('Sphinx Documentation subprocess failed with return '
                      'code ' + str(proc.returncode))
+            retcode = proc.returncode
 
         if retcode is not None:
             # this is potentially dangerous in that there might be something