BUG: Close Gzipfile in votable/utils properly.

Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
astropy · Sep 20, 2023 · 97b5c56 · 97b5c56
1 parent 7993d5f
commit 97b5c56
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/astropy/io/votable/util.py b/astropy/io/votable/util.py
@@ -76,10 +76,12 @@ def convert_to_writable_filelike(fd, compressed=False):
 
         if needs_wrapper:
             yield codecs.getwriter("utf-8")(fd)
-            fd.flush()
         else:
             yield fd
-            fd.flush()
+
+        fd.flush()
+        if isinstance(fd, gzip.GzipFile):
+            fd.close()
 
         return
     else:

diff --git a/docs/changes/io.votable/15358.bugfix.rst b/docs/changes/io.votable/15358.bugfix.rst
@@ -0,0 +1 @@
+Fixed a bug in ``convert_to_writable_filelike`` where ``GzipFile`` was not closed properly.