Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to project separation onto an ellipse #1012

Open
eteq opened this issue Apr 23, 2013 · 5 comments
Open

Add option to project separation onto an ellipse #1012

eteq opened this issue Apr 23, 2013 · 5 comments
Labels

Comments

@eteq
Copy link
Member

eteq commented Apr 23, 2013

Right now separation only gives the angle between two points. Another common "separation" in astronomy is the distance projected along a particular axis (e.g. the major axis of a galaxy). This would be particularly useful because of the rather sordid history of various people confusing which way a PA goes ("degrees east of north" I think is the most common convention).

Also useful (at least in galaxy contexts) might be an "elliptical" distance (where the separation along the major and minor axes is weighted by the ellipticity).

This should probably await until some of the significant coordinate internal changes are done, so I'm not targeting a particular milestone.

@balbinot
Copy link

Well I need exactly this for my research. I have a working code to do this (all conventions taken to account). I can try to contribute.

Do you think the coordinates API is mature enough to receive this addition?

@eteq
Copy link
Member Author

eteq commented Mar 25, 2014

@balbinot - the general API for defining coordinates will be changing in the upcoming version, but this part of it (separations) probably will not be. So contributing your code is definitely worthwhile - we will then be able to adapt it to the new scheme as we make the changes to the existing separation stuff.

@eteq eteq changed the title Add option to project separation onto a particular PA or ellipse Add option to project separation onto an ellipse Jul 11, 2014
@eteq
Copy link
Member Author

eteq commented Jul 11, 2014

Note that this was partially implemented in #2487, which did the circular/PA version. However, it would still be useful to add the "ellipse" part. So I've renamed this issue appropriately.

I've also tagged this effort-low/package-novice, as it's fairly straightforward either as an extra keyword to position_angle or as a new method to be called something like elliptical_pa.

@smeyerre
Copy link

smeyerre commented Feb 9, 2017

Hi @eteq, I was looking for something I could start on for a "first issue" and I thought I'd try this if it's still open. I just had a clarification question: I assume by "separation along the major and minor axes" you mean the distance projected along those axes. My question is: how should that be 'weighted' by the ellipticity? What's the weight function?

@pllim pllim added the good first issue Issues that are well-suited for new contributors label May 23, 2018
@Himanshu-Garg
Copy link

Himanshu-Garg commented Mar 19, 2019

is this still open?
interested in giving it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants