Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated output when evaluating a model with n_outputs=1 #12373

Closed
nden opened this issue Nov 3, 2021 · 0 comments · Fixed by #12380
Closed

Truncated output when evaluating a model with n_outputs=1 #12373

nden opened this issue Nov 3, 2021 · 0 comments · Fixed by #12380
Labels
Bug modeling
Milestone
v5.0

Comments

@nden
Copy link
Contributor

nden commented Nov 3, 2021

Description

This is a regression in 5.0x. When evaluating a model with one output and specifying with_bounding_box=True
the output is truncated

Expected behavior

from astropy.modeling.models import *

x = [1,2]
y = [3,4]

model = Mapping((1,))
model(x, y, with_bounding_box = True)
[3, 4]

Actual behavior

model(x, y, with_bounding_box = True)
3
@nden nden added this to the v5.0 milestone Nov 3, 2021
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this issue Nov 3, 2021
@WilliamJamieson
Added regression test for issue astropy#12373
6704993
@WilliamJamieson WilliamJamieson mentioned this issue Nov 3, 2021
Merged
9 tasks
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this issue Nov 3, 2021
@WilliamJamieson
Added regression test for issue astropy#12373
c84a584
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this issue Nov 3, 2021
@WilliamJamieson
Added regression test for issue astropy#12373
52935f9
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this issue Nov 4, 2021
@WilliamJamieson
Added regression test for issue astropy#12373
17c648c 
Initial fix for bug

Extended test to include a bounding box

Added regression test for compound models having the same issue

Fixed issue for compound models as well

Added changelog
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this issue Nov 4, 2021
@WilliamJamieson
Added regression test for issue astropy#12373
781f13c 
Initial fix for bug

Extended test to include a bounding box

Added regression test for compound models having the same issue

Fixed issue for compound models as well

Added changelog
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this issue Nov 4, 2021
@WilliamJamieson
Added regression test for issue astropy#12373
b939f8a 
Initial fix for bug

Extended test to include a bounding box

Added regression test for compound models having the same issue

Fixed issue for compound models as well

Added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug modeling
Projects
None yet
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Bugfix for truncated outputs when using with_bounding_box=True WilliamJamieson/astropy
1 participant
@nden