Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug creating QTable with units arg set #14357

Merged
merged 1 commit into from Feb 3, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 3, 2023

Description

This pull request is to fix a problem when a QTable is created and one or more columns are Quantity objects and units is provided to update the Quantity units.

Previously the code was always setting the column units attribute, but this does not work for Quantity. Instead in that case update the column unit in-place using the <<= operator.

Fixes #14336

@taldcroft taldcroft added the Bug label Feb 3, 2023
@taldcroft taldcroft added this to the v5.0.6 milestone Feb 3, 2023
@github-actions github-actions bot added the table label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@taldcroft taldcroft requested a review from mhvk February 3, 2023 19:28
@pllim pllim added 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x labels Feb 3, 2023
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short & sweet!

@mhvk mhvk merged commit 65b4e21 into astropy:main Feb 3, 2023
@lumberbot-app

This comment was marked as resolved.

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 3, 2023
pllim added a commit that referenced this pull request Feb 3, 2023
…357-on-v5.2.x

Backport PR #14357 on branch v5.2.x (Fix bug creating QTable with units arg set)
pllim pushed a commit to pllim/astropy that referenced this pull request Feb 6, 2023
…units

Fix bug creating QTable with units arg set

(cherry picked from commit 65b4e21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug table 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QTable units change after creation behaves inconsistently
3 participants