New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug creating QTable with units arg set #14357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
added
💤 backport-v5.0.x
on-merge: backport to v5.0.x
💤 backport-v5.2.x
on-merge: backport to v5.2.x
labels
Feb 3, 2023
mhvk
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short & sweet!
This comment was marked as resolved.
This comment was marked as resolved.
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Feb 3, 2023
pllim
added a commit
that referenced
this pull request
Feb 3, 2023
…357-on-v5.2.x Backport PR #14357 on branch v5.2.x (Fix bug creating QTable with units arg set)
pllim
pushed a commit
to pllim/astropy
that referenced
this pull request
Feb 6, 2023
…units Fix bug creating QTable with units arg set (cherry picked from commit 65b4e21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
table
💤 backport-v5.0.x
on-merge: backport to v5.0.x
💤 backport-v5.2.x
on-merge: backport to v5.2.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to fix a problem when a
QTable
is created and one or more columns areQuantity
objects andunits
is provided to update theQuantity
units.Previously the code was always setting the column
units
attribute, but this does not work forQuantity
. Instead in that case update the column unit in-place using the<<=
operator.Fixes #14336