Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual backport of PR 14357 onto v5.0.x (Fix bug creating QTable with units arg set) #14362

Merged
merged 1 commit into from Feb 6, 2023
Merged

Manual backport of PR 14357 onto v5.0.x (Fix bug creating QTable with units arg set) #14362

merged 1 commit into from Feb 6, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 6, 2023

Description

This pull request is to manually backport #14357 to v5.0.x

@mhvk @pllim
Merge pull request astropy#14357 from taldcroft/fix-qtable-init-with-…
f8b9cbd 
…units

Fix bug creating QTable with units arg set

(cherry picked from commit 65b4e21)
@pllim pllim added Manual Backport skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports labels Feb 6, 2023
@pllim pllim added this to the v5.0.6 milestone Feb 6, 2023
@pllim pllim requested review from taldcroft and mhvk February 6, 2023 00:04
@github-actions github-actions bot added the table label Feb 6, 2023
mhvk
mhvk approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All looks good. Failures seem unrelated (and should be fixed by #14358, I guess).

@mhvk mhvk added the 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Feb 6, 2023
@pllim pllim merged commit 57a9c5d into astropy:v5.0.x Feb 6, 2023
@pllim pllim deleted the backport-of-pr14357-to-v5.0.x branch February 6, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

@taldcroft taldcroft Awaiting requested review from taldcroft

Assignees
No one assigned
Labels
Manual Backport skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks table 💤 merge-when-ci-passes Do not use: We have auto-merge option now.
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pllim @mhvk