TST: Test against Python 3.12 pre-prelease #14784

pllim · 2023-05-07T16:09:27Z

Description

This pull request is to see if we will be compatible with Python 3.12 (#14783). Only the alpha is out, so I am feeling this is going to fail horribly now because we also need upstream stuff to be compatible first. We can always re-run this PR as needed.

Fix #14783

Close #15238 (hopefully)

Companion of #15331

TODO:

Confirm that nddata patch is correct.
Undo commenting out mpldev when they have 3.9.dev wheels uploaded.
Simplify build logic when numpy 1.26 is released for real.
Fix chronic remote data timeout in a separate PR. CI probably blocked it. TST: test_api_lookup also catches TimeoutError in CI #15355
Move votable bug fix into a separate PR. Python 3.12 smoked it out but it is its own thing. BUG: Close Gzipfile in votable/utils properly #15359
Investigate why devdeps still pulling in numpy 1.26.0 and not numpy-dev. matplotlib dev pulls in contourpy that pins numpy<2, preventing numpy dev testing matplotlib/matplotlib#26847

Blocked by:

Not blocker but linked to this PR:

github-actions · 2023-05-07T16:10:04Z

github-actions · 2023-05-07T16:10:09Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

pllim · 2023-08-17T21:31:56Z

Huh, why is the devdeps job not picking up numpy 2.0.dev wheel from https://anaconda.org/scientific-python-nightly-wheels/numpy/files ? They seem to have some cp312 ones.

pllim · 2023-08-17T21:33:48Z

Looks like asdf-astropy is downgrading numpy for some reason...

https://github.com/astropy/astropy/actions/runs/5896110330/job/15993310599?pr=14784

.github/workflows/ci_workflows.yml

WilliamJamieson · 2023-08-18T04:34:07Z

Looks like asdf-astropy is downgrading numpy for some reason...

astropy/astropy/actions/runs/5896110330/job/15993310599?pr=14784

It is not, for some reason it had oldest-supported-numpy as a build-system dependency which was never necessary.

astropy/asdf-astropy#193 should fix this.

pllim · 2023-08-18T22:20:22Z

pyerfa is still not playing well with Python 3.12 (see errors in liberfa/pyerfa#111). I have to disable it here.

pllim · 2023-08-19T01:05:13Z

Ah... maybe because numpy 1.25 does not have a cp312 wheel, so it is trying to build numpy from source before building astropy...

.github/workflows/publish.yml

pyproject.toml

mhvk · 2023-09-21T08:53:43Z

@pllim - the deprecation of np.char seems quite painful -- it appears we use it in quite a few places. I had a quick look and think the use in astropy.table is fairly easy to fix, but I'm more worried about io.fits... It may be an idea to just filter the warning for now here, so you can make wrap this up (of course, raising a separate issue...).

pllim · 2023-09-21T14:09:41Z

Actually the chararray stuff might not be as dire as it sounds. I only found one line that needed replacing I think. Let's see what the CI says over at #15363 🤞

Also have to catch KeyError in NDSlicingMixin for uncertainty and mask now. BLD: Add py312 wheels. BLD: Update cython to 0.29.36 for Python 3.12.

pllim · 2023-09-21T16:33:50Z

Of course there are conflicts. Otherwise it would be too easy. I'll take care of it.

mhvk · 2023-09-21T18:17:01Z

Thanks so much, @pllim!!! 🎆

for Pyhon 3.12. This was supposed to be in #14784 but got lost in rebase. Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>

pllim · 2023-09-21T18:57:18Z

maxnoe's Cython bump was lost in the rebase. I fixed at in 709ce95 in main. 😬

…e-prelease) (#15370) * Backport PR #14784: TST: Test against Python 3.12 pre-prelease * cosmology changed a lot * DOC: main has no more setup.cfg but that is irrelevant for v5.3.x so we just stop cross-ref.

pllim added Experimental no-changelog-entry-needed labels May 7, 2023

pllim added this to the v6.0 milestone May 7, 2023

pllim added the Python 3.12 label May 7, 2023

github-actions bot added the testing label May 7, 2023

pllim force-pushed the python-3.12 branch from a966ab4 to 0777454 Compare August 17, 2023 21:26

WilliamJamieson reviewed Aug 18, 2023

View reviewed changes

.github/workflows/ci_workflows.yml Outdated Show resolved Hide resolved

pllim mentioned this pull request Aug 18, 2023

Stop using oldest-supported-numpy liberfa/pyerfa#107

Merged

This comment was marked as resolved.

Sign in to view

pllim force-pushed the python-3.12 branch 2 times, most recently from 2c0a48d to 8a612a4 Compare August 18, 2023 21:43

pllim mentioned this pull request Aug 18, 2023

Add Python 3.12 job and wheels liberfa/pyerfa#111

Merged

2 tasks

pllim added Build all wheels Run all the wheel builds rather than just a selection and removed Experimental labels Aug 18, 2023

This comment was marked as resolved.

Sign in to view

pllim mentioned this pull request Aug 18, 2023

Add nightly wheels for Python 3.12 #15202

Closed

1 task

pllim force-pushed the python-3.12 branch 2 times, most recently from 83f954f to 288501d Compare August 19, 2023 02:38

pllim mentioned this pull request Aug 19, 2023

Add support for CIBW_ENVIRONMENT OpenAstronomy/github-actions-workflows#149

Closed

pllim commented Aug 19, 2023

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

pllim mentioned this pull request Aug 28, 2023

Test failures with Python 3.12 and astropy 5.3.2 #15238

Closed

pllim force-pushed the python-3.12 branch from fa71850 to 7aa3b7f Compare August 31, 2023 14:24

pllim mentioned this pull request Aug 31, 2023

DEP: stop building and testing 32-bit windows numpy/numpy#23717

Closed

pllim force-pushed the python-3.12 branch from 785b3ab to 3393339 Compare September 20, 2023 13:42

This comment was marked as resolved.

Sign in to view

bmorris3 reviewed Sep 20, 2023

View reviewed changes

pyproject.toml Show resolved Hide resolved

pllim mentioned this pull request Sep 20, 2023

BUG: Close Gzipfile in votable/utils properly #15359

Merged

1 task

pllim force-pushed the python-3.12 branch 2 times, most recently from e9a5bb2 to ff428a3 Compare September 21, 2023 00:52

This comment was marked as resolved.

Sign in to view

MNT: Python 3.12 compatibility fixes.

82c8b6d

Also have to catch KeyError in NDSlicingMixin for uncertainty and mask now. BLD: Add py312 wheels. BLD: Update cython to 0.29.36 for Python 3.12.

pllim force-pushed the python-3.12 branch from ff428a3 to 82c8b6d Compare September 21, 2023 15:51

pllim marked this pull request as ready for review September 21, 2023 16:10

pllim requested a review from taldcroft as a code owner September 21, 2023 16:10

WilliamJamieson approved these changes Sep 21, 2023

View reviewed changes

neutrinoceros approved these changes Sep 21, 2023

View reviewed changes

pllim enabled auto-merge September 21, 2023 16:26

pllim merged commit ea32c9c into astropy:main Sep 21, 2023
56 checks passed

This comment was marked as resolved.

Sign in to view

lumberbot-app bot added the Still Needs Manual Backport label Sep 21, 2023

pllim deleted the python-3.12 branch September 21, 2023 16:33

pllim added a commit that referenced this pull request Sep 21, 2023

BLD: Bump Cython to 0.29.36

709ce95

for Pyhon 3.12. This was supposed to be in #14784 but got lost in rebase. Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>

pllim added a commit to pllim/astropy that referenced this pull request Sep 21, 2023

Backport PR astropy#14784: TST: Test against Python 3.12 pre-prelease

b7055c9

pllim mentioned this pull request Sep 21, 2023

Backport PR #14784 on branch v5.3.x (TST: Test against Python 3.12 pre-prelease) #15370

Merged

1 task

pllim removed the Still Needs Manual Backport label Sep 21, 2023

pllim added a commit to pllim/astropy that referenced this pull request Sep 22, 2023

Backport PR astropy#14784: TST: Test against Python 3.12 pre-prelease

a7ec00c

pllim added a commit to pllim/astropy that referenced this pull request Sep 22, 2023

Backport PR astropy#14784: TST: Test against Python 3.12 pre-prelease

9d85960

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Test against Python 3.12 pre-prelease #14784

TST: Test against Python 3.12 pre-prelease #14784

pllim commented May 7, 2023 •

edited

github-actions bot commented May 7, 2023

github-actions bot commented May 7, 2023

pllim commented Aug 17, 2023

pllim commented Aug 17, 2023

WilliamJamieson commented Aug 18, 2023

This comment was marked as resolved.

pllim commented Aug 18, 2023

This comment was marked as resolved.

pllim commented Aug 19, 2023

This comment was marked as resolved.

This comment was marked as resolved.

mhvk commented Sep 21, 2023

pllim commented Sep 21, 2023

This comment was marked as resolved.

pllim commented Sep 21, 2023

mhvk commented Sep 21, 2023

pllim commented Sep 21, 2023

TST: Test against Python 3.12 pre-prelease #14784

TST: Test against Python 3.12 pre-prelease #14784

Conversation

pllim commented May 7, 2023 • edited

Description

github-actions bot commented May 7, 2023

github-actions bot commented May 7, 2023

pllim commented Aug 17, 2023

pllim commented Aug 17, 2023

WilliamJamieson commented Aug 18, 2023

This comment was marked as resolved.

pllim commented Aug 18, 2023

This comment was marked as resolved.

pllim commented Aug 19, 2023

This comment was marked as resolved.

This comment was marked as resolved.

mhvk commented Sep 21, 2023

pllim commented Sep 21, 2023

This comment was marked as resolved.

pllim commented Sep 21, 2023

mhvk commented Sep 21, 2023

pllim commented Sep 21, 2023

pllim commented May 7, 2023 •

edited