Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Close Gzipfile in votable/utils properly #15359

Merged
merged 1 commit into from Sep 21, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented Sep 20, 2023

Description

This pull request is to separate out the io.votable bugfix that Python 3.12 smoked out at #14784 because:

  • the other PR just drags on, and
  • this bug fix could potentially benefit LTS too.

Credit for this fix goes to @maxnoe , whom I credited as co-author.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added Bug 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x labels Sep 20, 2023
@pllim pllim added this to the v5.0.9 milestone Sep 20, 2023
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
@pllim
Copy link
Member Author

pllim commented Sep 20, 2023

Why is RTD so slow? 😒

@pllim
Copy link
Member Author

pllim commented Sep 21, 2023

This was already reviewed and approved in the other PR, so merging.

@pllim pllim merged commit b74412c into astropy:main Sep 21, 2023
25 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 21, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 21, 2023
@pllim pllim deleted the votable-gzip-bugfix branch September 21, 2023 00:22
pllim added a commit that referenced this pull request Sep 21, 2023
…359-on-v5.3.x

Backport PR #15359 on branch v5.3.x (BUG: Close Gzipfile in votable/utils properly)
pllim added a commit that referenced this pull request Sep 21, 2023
…359-on-v5.0.x

Backport PR #15359 on branch v5.0.x (BUG: Close Gzipfile in votable/utils properly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug io.votable 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant