New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Close Gzipfile in votable/utils properly #15359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
Bug
💤 backport-v5.0.x
on-merge: backport to v5.0.x
💤 backport-v5.3.x
on-merge: backport to v5.3.x
labels
Sep 20, 2023
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
pllim
force-pushed
the
votable-gzip-bugfix
branch
from
September 20, 2023 20:58
97b5c56
to
1d8e464
Compare
6 tasks
Why is RTD so slow? 😒 |
This was already reviewed and approved in the other PR, so merging. |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Sep 21, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Sep 21, 2023
pllim
added a commit
that referenced
this pull request
Sep 21, 2023
…359-on-v5.3.x Backport PR #15359 on branch v5.3.x (BUG: Close Gzipfile in votable/utils properly)
pllim
added a commit
that referenced
this pull request
Sep 21, 2023
…359-on-v5.0.x Backport PR #15359 on branch v5.0.x (BUG: Close Gzipfile in votable/utils properly)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
io.votable
💤 backport-v5.0.x
on-merge: backport to v5.0.x
💤 backport-v5.3.x
on-merge: backport to v5.3.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to separate out the
io.votable
bugfix that Python 3.12 smoked out at #14784 because:Credit for this fix goes to @maxnoe , whom I credited as co-author.