Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure names of Quantity and other mixin columns are propagated #15848

Merged
merged 2 commits into from Jan 10, 2024

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Jan 10, 2024

When initializing a column from a quantity with Column(quantity) currently it is checked whether quantity.info exists and description, format, and meta are taken from it, but not the name. This fixes that.

I found this while trying to address the fact that the name of a quantity column in QTable was not propagated to the label in MRT format (see #12804). However, it turned out that was because for any mixin column, the name was not used. So, that is corrected in the second commit.

Fixes #12804

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added table io.ascii Bug backport-v6.0.x on-merge: backport to v6.0.x labels Jan 10, 2024
@mhvk mhvk added this to the v6.0.1 milestone Jan 10, 2024
@mhvk mhvk requested a review from hamogu January 10, 2024 18:29
Copy link

github-actions bot commented Jan 10, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@hamogu
Copy link
Member

hamogu commented Jan 10, 2024

Except for @eerovaher comment (which is really nitpicky), this is good to go.

@mhvk mhvk force-pushed the quantity-columns-and-mrt-output branch from 36a54ab to 4dd8327 Compare January 10, 2024 21:12
@hamogu hamogu enabled auto-merge January 10, 2024 21:16
@hamogu hamogu merged commit 5fd8f47 into astropy:main Jan 10, 2024
26 checks passed

This comment was marked as resolved.

@pllim

This comment was marked as resolved.

mhvk pushed a commit to mhvk/astropy that referenced this pull request Jan 10, 2024
mhvk added a commit that referenced this pull request Jan 10, 2024
Backport PR #15848: Ensure names of Quantity and other mixin columns are propagated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v6.0.x on-merge: backport to v6.0.x Bug io.ascii table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ascii.mrt format does not keep column names consistently
4 participants