-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure names of Quantity and other mixin columns are propagated #15848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
eerovaher
reviewed
Jan 10, 2024
Except for @eerovaher comment (which is really nitpicky), this is good to go. |
36a54ab
to
4dd8327
Compare
hamogu
approved these changes
Jan 10, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mhvk
pushed a commit
to mhvk/astropy
that referenced
this pull request
Jan 10, 2024
…olumns are propagated
mhvk
added a commit
that referenced
this pull request
Jan 10, 2024
Backport PR #15848: Ensure names of Quantity and other mixin columns are propagated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a column from a quantity with
Column(quantity)
currently it is checked whetherquantity.info
exists anddescription
,format
, andmeta
are taken from it, but not the name. This fixes that.I found this while trying to address the fact that the name of a quantity column in
QTable
was not propagated to the label inMRT
format (see #12804). However, it turned out that was because for any mixin column, the name was not used. So, that is corrected in the second commit.Fixes #12804