Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test_quantity_ufuncs.py fails when numpy-dev is used without scipy #16100

Closed
pllim opened this issue Feb 23, 2024 · 2 comments · Fixed by #16102
Closed

TST: test_quantity_ufuncs.py fails when numpy-dev is used without scipy #16100

pllim opened this issue Feb 23, 2024 · 2 comments · Fixed by #16102

Comments

@pllim
Copy link
Member

pllim commented Feb 23, 2024

Example log: https://github.com/astropy/astropy/actions/runs/8025362924/job/21925825752

FAILED units/tests/test_quantity_ufuncs.py::TestUfuncHelpers::test_coverage -
AssertionError: assert {<ufunc 'isti...unc 'rindex'>} == set()
  
  Extra items in the left set:
  <ufunc 'istitle'>
  <ufunc 'isalnum'>
  <ufunc 'index'>
  <ufunc 'islower'>
  <ufunc 'isupper'>
  <ufunc 'rindex'>
  
  Full diff:
  - set()
  + {
  +     <ufunc 'index'>,
  +     <ufunc 'isalnum'>,
  +     <ufunc 'islower'>,
  +     <ufunc 'istitle'>,
  +     <ufunc 'isupper'>,
  +     <ufunc 'rindex'>,
  + }

@mhvk and @neutrinoceros , you have been on top of this lately, do you have idea how to fix? Thanks!

p.s. Thanks to @dhomeier's foresight to ask for this combo!

@dhomeier
Copy link
Contributor

numpy/numpy#25791; should probably be added to UNSUPPORTED_UFUNCS in helpers.py following suite in #15525.

@mhvk
Copy link
Contributor

mhvk commented Feb 24, 2024

Indeed, they are string ufuncs that Quantity does not support - but should be OK with Masked

mhvk added a commit that referenced this issue Feb 25, 2024
MAINT: ignore more unsupported string ufuncs for Quantity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants