Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit float/int representation for progress bar #2201

Closed
astrofrog opened this issue Mar 15, 2014 · 7 comments
Closed

Fit float/int representation for progress bar #2201

astrofrog opened this issue Mar 15, 2014 · 7 comments

Comments

@astrofrog
Copy link
Member

For iterables with sizes that don't require suffixes in the progress bar, it might make more sense to use integers:

In [2]: from astropy.utils.console import ProgressBar

In [3]: ProgressBar([1,2,3]) 
|>------------------------------------------| 0.0 /3.0  (  0.00%)

Tagging as low-priority and easy in case a GSoC student or other first time contributor wants to give it a try.

@CNA-Bld
Copy link

CNA-Bld commented Mar 16, 2014

I would like to try to work on this.
Please check if I understand the issue correctly: the 0.0 /3.0 part in the progress bar should be changed to 0 /3.

@astrofrog
Copy link
Member Author

@CNA-Bld - @orangeblock has already filed a pull request for this (#2202)

@CNA-Bld
Copy link

CNA-Bld commented Mar 16, 2014

@astrofrog Ooops I was using mobile phone and never noticed that... Thank you anyway!

@mdboom
Copy link
Contributor

mdboom commented Mar 17, 2014

@astrofrog: I think #2202 is unrelated. It has to do with the display of file sizes. The bug report here has to do with percentage completion.

@astrofrog
Copy link
Member Author

@mdboom - actually I meant for the issue here to not be to do with the percentage (which is fine as-is) but my problem above was the 1.0 / 3.0 which I thought is what was fixed in #2202?

@mdboom
Copy link
Contributor

mdboom commented Mar 17, 2014

@astrofrog: Indeed. You are right.

@mdhoney mdhoney mentioned this issue Jul 11, 2014
@embray embray modified the milestones: v1.0.0, Future Jan 15, 2015
@embray
Copy link
Member

embray commented Jan 15, 2015

Fixed in #3299 .

@embray embray closed this as completed Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants