Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astropy != AstroPy ??? #24

Closed
mdboom opened this issue Oct 18, 2011 · 3 comments
Closed

astropy != AstroPy ??? #24

mdboom opened this issue Oct 18, 2011 · 3 comments

Comments

@mdboom
Copy link
Contributor

mdboom commented Oct 18, 2011

Is there a good reason for the distutils/setuptools/egg name being different from the Python package name? It's currently defined as "AstroPy" in the setup.py.

Maybe this doesn't matter (sorry to be pedantic), but I find this confusing for the following reasons:

  1. I use a tool that cleans my virtualenv by deleting packages by name -- if its name on disk is different from how it's imported I have to remember which is which

  2. "pip install AstroPy" someday will confuse people

  3. tarballs and installers built with distutils won't match the name of the git repository

@phn
Copy link
Contributor

phn commented Oct 19, 2011

Hello,

The command pip install astropy will work even if the module is named "AstroPy".

Prasanth

@eteq
Copy link
Member

eteq commented Oct 19, 2011

I've seen this in other packages, and it doesn't seem to present too many problems... As Prasanth says various tools seem to generally be able to figure it out.

But having said that, the no really good reason for the capitalized form, either. So I see your point that it makes sense to change the name to astropy so that it's all the same regardless.

As long as there are no objections, I'll just go ahead and change the name in setup.py from AstroPy to astropy

@eteq
Copy link
Member

eteq commented Oct 24, 2011

Fixed in commit cb58b73

@eteq eteq closed this as completed Oct 24, 2011
embray added a commit to embray/astropy that referenced this issue Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants