Fix bug in Table init with multidim input data #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
force-pushed
the
table-init-multidim
branch
from
5316dd0
to
c32fe57
Compare
|
@astrofrog - this is needed to (easily) implement the "table init from ndarray" benchmark using the existing ndarray (which has a multi-dim table). This is how I originally discovered this bug. Pretty simple and non-controversial patch for review. |
|
@taldcroft - I guess this needs rebasing, but looks good. FIne to merge once travis passes (on the rebase). |
taldcroft
force-pushed
the
table-init-multidim
branch
from
c32fe57
to
241218d
Compare
|
OK rebased (conflict in CHANGES.rst). |
|
@mhvk - thanks for your reviews! |
taldcroft
added a commit
that referenced
this pull request
Oct 21, 2014
Fix bug in Table init with multidim input data
taldcroft
added a commit
that referenced
this pull request
Dec 31, 2014
Fix bug in Table init with multidim input data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a failure when creating a new Table from an ndarray structured array where one of the columns was multidimensional and copy=True. This was due to ignoring the column shape when creating the new
_dataarray.