Correct Quantity.list to .tolist, overriding the correct ndarray method #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@embray - this is really a trivial change, and my main uncertainty is about whether it should have a changelog entry, and whether you want it backported. Thanks! |
|
Could you remove the change to the astropy_helpers submodule and add a bugfix entry to the changelog? |
|
@embray - bugfix for 0.4 or 1.0? |
|
@embray - I picked 0.4.3 as the milestone, since it is a bug in 0.4 as well. Can change if you prefer, but if you think it is fine, just go ahead and merge. |
|
Sounds fine to me. |
embray
added a commit
that referenced
this pull request
Oct 27, 2014
Correct Quantity.list to .tolist, overriding the correct ndarray method
embray
added a commit
that referenced
this pull request
Dec 31, 2014
Correct Quantity.list to .tolist, overriding the correct ndarray method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
ndarraymethods, I noticedQuantitydoes not overridetolist, but instead mistakenly has alistmethod. This PR corrects this mistake. Strictly, this is a bug, but since.listonly gives aNotImplementedErrorit is probably not worth backporting.