Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added thomson scattering cross section to si units #3839

Merged
merged 2 commits into from Jun 11, 2015

Conversation

dannygoldstein
Copy link
Contributor

Self-explanatory.

@pllim
Copy link
Member

pllim commented Jun 10, 2015

  1. Why 0.6652458734e-28 and not 6.652458734e-29?
  2. Add a change log.

@mdboom
Copy link
Contributor

mdboom commented Jun 10, 2015

Needs an entry in CHANGES.rst

@dannygoldstein
Copy link
Contributor Author

  1. Using the exact value of sigma_T as it appears here.
  2. Done.

@pllim
Copy link
Member

pllim commented Jun 10, 2015

Okay, I don't see anything controversial here. 👍 to merging when tests pass.

@embray
Copy link
Member

embray commented Jun 10, 2015

Certainly no problem with adding this. Though it makes me think there are countless other constants we could be adding easily. I'm almost tempted to make the constants module into just a big text file, from which constants can be lazy-loaded on-demand (so that when you just need one of them it's not necessary to create Constant objects for all of them).

@mhvk mhvk self-assigned this Jun 11, 2015
@mhvk
Copy link
Contributor

mhvk commented Jun 11, 2015

Since this looks all OK, I was about to merge this, but then I wondered about internal consistency, since the thomson cross-section can be calculated from constants we have already:

n [3]: 0.6652458734e-28*u.m**2 - 8*np.pi/3.*(c.alpha*c.hbar/c.m_e/c.c)**2
Out[3]: <Quantity 9.45122676949322e-38 m2>

Fortunately, the result is consistent!

It does beg the question, though, on what to calculate and what to store (e.g., we don't have the radiation constant a but do have the stefan-boltzmann constant).

Anyway, this is probably best done in another issue...

mhvk added a commit that referenced this pull request Jun 11, 2015
added thomson scattering cross section to si units
@mhvk mhvk merged commit a5ce6bc into astropy:master Jun 11, 2015
@mhvk
Copy link
Contributor

mhvk commented Jun 11, 2015

See #3843 for the broader issues raised here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants