Plot style should not set interactive #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @hamogu |
|
I think we should put this in v1.0.4. I think the fact that that was there in the first place should be a bug. |
|
Ok -- I think I agree. I've moved the CHANGES entry to 1.0.4. |
|
Thanks! |
embray
added a commit
that referenced
this pull request
Aug 4, 2015
Plot style should not set interactive
embray
added a commit
that referenced
this pull request
Aug 5, 2015
Plot style should not set interactive
embray
added a commit
that referenced
this pull request
Aug 7, 2015
Plot style should not set interactive
embray
added a commit
that referenced
this pull request
Aug 11, 2015
Plot style should not set interactive
embray
added a commit
that referenced
this pull request
Aug 11, 2015
Plot style should not set interactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A style should not tinker with the interactive mode. Importantly, this means if you use it in a non-interactive context, such as building Sphinx docs or in a web server the plots take on the order of 10-20x longer to render.
This is somewhat a matplotlib bug that this even works in the first place (see matplotlib/matplotlib#4855).
However, in the meantime, I think we should just remove this from
astropy_mpl_style.Not exactly sure how to milestone this -- it probably belongs as a bugfix, but's it could trip someone up who was inadvertently depending on this behavior.