Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop numpy 1.7 and 1.8 from tests and code #6006

Merged
merged 5 commits into from May 8, 2017
Merged

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented May 4, 2017

This replaces #6003, with all work-arounds for numpy 1.7 and 1.8 removed (only a handful left!).

@pllim
Copy link
Member

pllim commented May 4, 2017

No change log needed? Shouldn't there be at least an entry that says Numpy 1.7 and 1.8 are no longer supported?

@mhvk
Copy link
Contributor Author

mhvk commented May 4, 2017

I think this gets done in the release notes, but you're right, might as well note it in the changelog, so we don't forget to add it!

CHANGES.rst Outdated
@@ -231,6 +231,7 @@ Other Changes and Additions

- Nothing changed yet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed

@astrofrog
Copy link
Member

Note that setup.py also needs to be required to enforce the minimum version of Numpy

@mhvk
Copy link
Contributor Author

mhvk commented May 4, 2017

Thanks! Also noticed circle is on 1.8, so that needs to change too. I updated things accordingly (I hope there is a 32-bit astropy docker image with 1.9...)

@mhvk
Copy link
Contributor Author

mhvk commented May 4, 2017

OK, my super-simple change for the docker image failed: how does one get a new one?

@mhvk
Copy link
Contributor Author

mhvk commented May 4, 2017

OK, all now passes except that for circleci we need a new docker image that has numpy >=1.9 installed. I have no idea how to go about that...

@bsipocz
Copy link
Member

bsipocz commented May 4, 2017

@astrofrog has the permission to upload a new docker image. What about creating one with a newer numpy that we could also use for v3.0dev? We also need a new one for the affiliated packages as the current one still runs np1.8 with astropy 1.2.1 (astropy/photutils#503 (comment))

@astrofrog
Copy link
Member

Here is the repository where the docker image can be built:

https://github.com/astropy/astropy-docker/tree/master/32bit

It might be good for someone else to do this to make sure I am not a single point of failure (and I'm happy to add permissions to the docker hub for other people to upload).

@bsipocz
Copy link
Member

bsipocz commented May 4, 2017

Looking at the system requirements of docker, my laptop is at the edge of being supported (old os, with small RAM and hardly any free space). I could possibly borrow another one when needed, but it makes more sense for someone else stepping up for the task.

@mhvk
Copy link
Contributor Author

mhvk commented May 4, 2017

Sorry, don't have time to investigate things beyond what I can easily do in Debian.

@larrybradley
Copy link
Member

larrybradley commented May 5, 2017

@astrofrog I can update the docker image, but I need permissions.

EDIT: My docker hub username is lbradley.

@astrofrog
Copy link
Member

@larrybradley - you should now have permissions

@larrybradley
Copy link
Member

I uploaded a new docker image with numpy 1.12.1 (the latest release) and the CircleCI test passed. All is green now.

@astrofrog Can you give me permission to upload the new Dockerfile to astropy-docker? I didn't update the 32bit-with-astropy image (for affiliated packages). Should I do that too?

@mhvk
Copy link
Contributor Author

mhvk commented May 8, 2017

@larrybradley - thanks very much! Since I think there was general agreement on this change, in it goes!

@mhvk mhvk merged commit 34e6680 into astropy:master May 8, 2017
@mhvk mhvk deleted the pr-6003 branch May 8, 2017 20:14
@astrofrog
Copy link
Member

@larrybradley - you now have permissions to upload the new Dockerfile to astropy-docker, can you do this? I have some other changes I need to make to the Dockerfile, and can regenerate the 32bit-with-astropy one once that's done.

@astrofrog astrofrog mentioned this pull request May 9, 2017
6 tasks
@larrybradley
Copy link
Member

@astrofrog Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants