Only keep Header values from the Primary that are not present in extension. #6489
Conversation
|
Hi there @MSeifert04 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 |
|
Do you check for |
|
No 😓 That PR just makes sure the primary header values have no precedence over the extension header values (now it's the other way around). I think this is now an "always |
|
I haven't see any actual file with |
|
I created an issue for it. It also affects other paths of the This PR is somewhat needed to fix the ccdproc test suite (which fails against master) so I would like this to be part of 2.0.2 :) |
|
@mwcraig do you have time to review this? |
|
@bsipocz This really should be in 2.0.2 (if someone reviews it) because |
|
@MSeifert04 - I'm afraid this also missed the release, but we probably can have a 2.0.3 soon after the CC meeting. |
|
okay, let me know as soon as there is a 2.0.3 section in the changelog. I'll move the changelog then. :) |
|
I'm waiting for the wheel builds to kick off, so hopefully within an our can push up the new changelog, etc. |
|
@MSeifert04 - the changelog section is now in master. |
|
@mwcraig @crawfordsm Could you have a look? We merged a similar PR in |
|
There are some conflicts -- FYI |
…nsion. In case a CCDData is read from a file and the primary HDU does not contain an image it will search for the first extension with data. In that case the Header is combined, but previously useful values like NAXIS, etc. were discarded in that operation.
|
Thanks for the heads up @pllim , conflicts should be fixed now :) |
MSeifert04
deleted the
ccddata_fix_problem_with_header_combine_reader
branch
…der_combine_reader Only keep Header values from the Primary that are not present in extension.
In case a CCDData is read from a file and the primary HDU does not contain an image it will search for the first extension with data. In that case the Header is combined, but previously useful values like NAXIS, etc. were discarded in that operation.