You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I stumbled upon io/fits/_numpy_hacks.py, which has a comment that says it can be retired when numpy/numpy#6430 is merged. That Numpy fix was incorporated into Numpy 1.12, which means we can remove this hack when our minversion for Numpy is 1.12.
(I am tempted to set this to novice but I probably shouldn't.)
The text was updated successfully, but these errors were encountered:
The best approach would probably be to modify the source code to explicitly have NUMPY_LT_112 so that we can then search/replace whenever we update the minimum Numpy version.
Oh, I guess you don't need that label... I just wanted something to indicate that this depends on upstream changes but I guess it is unnecessary given the milestone.
I stumbled upon
io/fits/_numpy_hacks.py
, which has a comment that says it can be retired when numpy/numpy#6430 is merged. That Numpy fix was incorporated into Numpy 1.12, which means we can remove this hack when ourminversion
for Numpy is 1.12.(I am tempted to set this to novice but I probably shouldn't.)
The text was updated successfully, but these errors were encountered: